Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] fix prefix url on locale api path #15311

Merged
merged 2 commits into from Sep 18, 2023
Merged

[API] fix prefix url on locale api path #15311

merged 2 commits into from Sep 18, 2023

Conversation

oallain
Copy link
Member

@oallain oallain commented Sep 15, 2023

Q A
Branch? 1.12
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

@probot-autolabeler probot-autolabeler bot added the API APIs related issues and PRs. label Sep 15, 2023
@oallain oallain changed the title fix prefix url on locale api path [API] fix prefix url on locale api path Sep 15, 2023
@oallain oallain marked this pull request as ready for review September 15, 2023 17:07
@oallain oallain requested a review from a team as a code owner September 15, 2023 17:07
@github-actions
Copy link

github-actions bot commented Sep 15, 2023 •
edited

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

@jakubtobiasz
Copy link
Member

Were these missing / causing any troubles or that's only a cosmetic change?

@oallain
Copy link
Member Author

oallain commented Sep 15, 2023

Were these missing / causing any troubles or that's only a cosmetic change?

After a few checks, ApiPlatform automatically adds the /, so it's just cosmetic.

jakubtobiasz
jakubtobiasz previously approved these changes Sep 15, 2023
View reviewed changes
diimpp
diimpp reviewed Sep 15, 2023
View reviewed changes
Copy link
Member

@diimpp diimpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one more at Order.xml

Sylius/src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/Order.xml

Line 24 in 104bc12

<attribute name="path">admin/orders</attribute>

@jakubtobiasz jakubtobiasz merged commit 4fb30dc into Sylius:1.12 Sep 18, 2023
25 checks passed
@jakubtobiasz
Copy link
Member

Thank you, @oallain!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diimpp diimpp diimpp approved these changes

@Roshyo Roshyo Roshyo approved these changes

@jakubtobiasz jakubtobiasz jakubtobiasz approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oallain @jakubtobiasz @diimpp @Roshyo