Provide the State Machine abstraction #15315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubtobiasz
added
the
DX
Bunnyshell Preview Environment deletedAvailable commands:
|
diimpp
reviewed
Sep 16, 2023
src/Sylius/Bundle/CoreBundle/StateMachine/CompositeStateMachine.php
Outdated
Show resolved
Hide resolved
|
Thanks for mentioning about twig functions, I totally forgot about them 😅. |
jakubtobiasz
force-pushed
the
SYL-2988
branch
from
1a23a25
to
09b70b9
Compare
jakubtobiasz
force-pushed
the
SYL-2988
branch
from
c0313c5
to
8a3df8a
Compare
jakubtobiasz
changed the title
jakubtobiasz
changed the title
jakubtobiasz
force-pushed
the
SYL-2988
branch
from
518a60d
to
67872fb
Compare
jakubtobiasz
force-pushed
the
SYL-2988
branch
from
67872fb
to
258ee8b
Compare
Rafikooo
approved these changes
Sep 19, 2023
jakubtobiasz
commented
Sep 20, 2023
Comment on lines
+25
to
+28
| /** | ||
| * @return array<string>|null | ||
| */ | ||
| public function getTos(): ?array; |
There was a problem hiding this comment.
We want to be compatible with Workflow, so despite Winzou allows to return only 1 "to", we return an array to tos.
NoResponseMate
approved these changes
Sep 20, 2023
GSadee
approved these changes
Sep 21, 2023
Comment on lines
+101
to
+110
| ->arrayNode('state_machine') | ||
| ->addDefaultsIfNotSet() | ||
| ->children() | ||
| ->scalarNode('default_adapter')->defaultValue('winzou_state_machine')->end() | ||
| ->arrayNode('graphs_to_adapters_mapping') | ||
| ->useAttributeAsKey('graph_name') | ||
| ->scalarPrototype()->end() | ||
| ->end() | ||
| ->end() | ||
| ->end() |
There was a problem hiding this comment.
I wonder if we shouldn't deprecate this config immediately after adding it
|
Thank you, Jacob! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
State machine adapters are configurable now!
It means we can enable Symfony Workflow one by one for our graphs :).