Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maintenance] Change trigger_error to trigger_deprecation #15323

Merged
merged 8 commits into from Sep 20, 2023
Merged

[Maintenance] Change trigger_error to trigger_deprecation #15323

merged 8 commits into from Sep 20, 2023

Conversation

Rafikooo
Copy link
Contributor

Q A
Branch? 1.13
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
License MIT

We need to sort out the deprecations as only one way is currently supported

@Rafikooo Rafikooo added the Maintenance CI configurations, READMEs, releases, etc. label Sep 18, 2023
@Rafikooo Rafikooo requested a review from a team as a code owner September 18, 2023 12:15
@probot-autolabeler probot-autolabeler bot added Admin AdminBundle related issues and PRs. API APIs related issues and PRs. Documentation Documentation related issues and PRs - requests, fixes, proposals. Shop ShopBundle related issues and PRs. labels Sep 18, 2023
@github-actions
Copy link

github-actions bot commented Sep 18, 2023 •
edited

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

jakubtobiasz
jakubtobiasz requested changes Sep 19, 2023
View reviewed changes
Copy link
Member

@jakubtobiasz jakubtobiasz left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check all string, as it's almost in every one xD. Janek asked to remove the since x.y from a given file, but you missed there're more places with it :D. I've added suggestion for 5 files, but I see it's a Sisyphean labour xD.

...tributeBundle/Form/Type/AttributeType/Configuration/SelectAttributeChoicesCollectionType.php Outdated Show resolved Hide resolved
src/Sylius/Bundle/CoreBundle/Application/Kernel.php Outdated Show resolved Hide resolved
src/Sylius/Bundle/CoreBundle/Fixture/BookProductFixture.php Outdated Show resolved Hide resolved
src/Sylius/Bundle/CoreBundle/Fixture/Factory/AdminUserExampleFactory.php Outdated Show resolved Hide resolved
src/Sylius/Bundle/CoreBundle/Fixture/Factory/AdminUserExampleFactory.php Outdated Show resolved Hide resolved
jakubtobiasz
jakubtobiasz reviewed Sep 19, 2023
View reviewed changes
Copy link
Member

@jakubtobiasz jakubtobiasz left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2023-09-19 at 14 26 05
You still missed some cases :D.

Use the files tab in the PR to find them all, IDE sometimes is not able to display all occurrences.

jakubtobiasz
jakubtobiasz previously approved these changes Sep 20, 2023
View reviewed changes
@jakubtobiasz
Copy link
Member

As I have issues with our merging tool, merge it on your own @Rafikooo please.

@jakubtobiasz jakubtobiasz merged commit f32c1fc into Sylius:1.13 Sep 20, 2023
27 checks passed
@jakubtobiasz
Copy link
Member

Thank you, @Rafikooo!

@GSadee GSadee mentioned this pull request Sep 21, 2023
Merged
Rafikooo added a commit that referenced this pull request Sep 21, 2023
@Rafikooo
minor #15335 Minor typo fix in deprecation message in ZoneChoiceType …
2740020 
…(GSadee)

This PR was merged into the 1.13 branch.

Discussion
----------

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.13|
| Bug fix?        | no                                                      |
| New feature?    | no                                                      |
| BC breaks?      | no                                                      |
| Deprecations?   | no|
| Related tickets | after #15323                      |
| License         | MIT                                                          |

<!--
 - Bug fixes must be submitted against the 1.12 branch
 - Features and deprecations must be submitted against the 1.13 branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------
  Minor typo fix in deprecation message in ZoneChoiceType
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee left review comments

@NoResponseMate NoResponseMate NoResponseMate left review comments

@Wojdylak Wojdylak Wojdylak approved these changes

@jakubtobiasz jakubtobiasz jakubtobiasz approved these changes

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs. API APIs related issues and PRs. Documentation Documentation related issues and PRs - requests, fixes, proposals. Maintenance CI configurations, READMEs, releases, etc. Shop ShopBundle related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Rafikooo @jakubtobiasz @GSadee @NoResponseMate @Wojdylak