Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API][Admin] Managing products #15399

Merged
merged 24 commits into from Oct 25, 2023
Merged

[API][Admin] Managing products #15399

merged 24 commits into from Oct 25, 2023

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Oct 4, 2023

Q A
Branch? 1.13
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets
License MIT

@GSadee GSadee added Feature New feature proposals. Admin AdminBundle related issues and PRs. API APIs related issues and PRs. labels Oct 4, 2023
@github-actions
Copy link

github-actions bot commented Oct 9, 2023 •
edited

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

@GSadee GSadee force-pushed the api-managing-products branch 5 times, most recently from 20f7ce6 to 6eb2451 Compare October 11, 2023 07:55
@GSadee GSadee marked this pull request as ready for review October 11, 2023 09:19
@GSadee GSadee requested a review from a team as a code owner October 11, 2023 09:19
NoResponseMate
NoResponseMate reviewed Oct 19, 2023
View reviewed changes
src/Sylius/Behat/Context/Api/Admin/ManagingProductsContext.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Api/Admin/ManagingProductsContext.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Api/Admin/ManagingProductsContext.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Api/Admin/ManagingProductsContext.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Api/Admin/ManagingProductsContext.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Ui/Admin/ManagingProductsContext.php Show resolved Hide resolved
src/Sylius/Bundle/ApiBundle/Serializer/ProductDenormalizer.php Outdated Show resolved Hide resolved
src/Sylius/Bundle/ApiBundle/Serializer/ProductDenormalizer.php Outdated Show resolved Hide resolved
src/Sylius/Bundle/ApiBundle/Serializer/ProductDenormalizer.php Outdated Show resolved Hide resolved
src/Sylius/Bundle/ApiBundle/Serializer/ProductDenormalizer.php Outdated Show resolved Hide resolved
@GSadee
[Behat] Mark scenarios for accessing variants management as no-api
1f08df0
@GSadee
[API][Admin] Extend GET endpoints for getting products
85a2555
@GSadee
[API][Admin] Extend POST endpoint for creating a product
1536fd3
@GSadee
[API] Extend PUT endpoint for updating the product
24f56b3
@GSadee
[API] Cover DELETE endpoint for product in contract tests
242cdc3
@GSadee
[Behat][API] Cover managing attribute values on product
4210f4a
@GSadee
[Behat][API] Refactor implementation of managing attribute values on …
bd3d740 
…product
@GSadee
[Behat][API] Cover scenarios for adding a product
c4324e5
@GSadee
[Behat] Mark scenarios for accessing product show page from admin as …
20d81ef 
…no-api
@GSadee
[Behat] Make features names for toggling inventory and simple product…
9d167bc 
…s consistent with other
@GSadee
[Behat][API] Cover scenarios for editing an existing product
b6a2f16
@GSadee
[Behat][API] Cover scenarios for preventing deletion of purchased pro…
19eef45 
…duct
@GSadee
[Behat] Mark scenarios for removing product price from simple product…
f7be453 
…s as no-api
@GSadee
[Behat][API] Cover scenarios for validating a product
ba1a1b0
@GSadee
[Behat][API] Cover scenarios for validating setting attributes on a p…
8bf40cc 
…roduct
@GSadee
[API] Fix static analysis
c25ee45
Wojdylak
Wojdylak previously approved these changes Oct 23, 2023
View reviewed changes
src/Sylius/Behat/Context/Ui/Admin/ManagingProductsContext.php Outdated Show resolved Hide resolved
@NoResponseMate NoResponseMate merged commit 0bc88ea into Sylius:1.13 Oct 25, 2023
25 checks passed
@NoResponseMate
Copy link
Contributor

Thank you, @GSadee!

@GSadee GSadee deleted the api-managing-products branch October 25, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoResponseMate NoResponseMate NoResponseMate approved these changes

@Wojdylak Wojdylak Wojdylak approved these changes

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs. API APIs related issues and PRs. Feature New feature proposals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GSadee @NoResponseMate @Wojdylak