Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API][Maintenance] Remove usage of deprecated IriConverter #15407

Merged
merged 2 commits into from Oct 6, 2023
Merged

[API][Maintenance] Remove usage of deprecated IriConverter #15407

merged 2 commits into from Oct 6, 2023

Conversation

NoResponseMate
Copy link
Contributor

Q A
Branch? 1.13
Bug fix? no
New feature? no
BC breaks? no?
Deprecations? no
Related tickets -
License MIT

@NoResponseMate NoResponseMate added Maintenance CI configurations, READMEs, releases, etc. API APIs related issues and PRs. labels Oct 5, 2023
@NoResponseMate NoResponseMate requested a review from a team as a code owner October 5, 2023 15:29
@github-actions
Copy link

github-actions bot commented Oct 5, 2023 •
edited

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

Rafikooo
Rafikooo reviewed Oct 6, 2023
View reviewed changes
UPGRADE-API-1.13.md Show resolved Hide resolved
UPGRADE-API-1.13.md Show resolved Hide resolved
@NoResponseMate
[API][Maintenance] Swap deprecated IriConverterInterface for the not …
d133ce7 
…deprecated one
@NoResponseMate
[API][Behat] Create a wrapper for iri conversion
24f7f9d 
[API][Behat] Extract section aware iri conversion into a standalone service
@NoResponseMate NoResponseMate force-pushed the SYL-3110/dedeprecate-apip-service-dependencies branch from 2a0e7be to 24f7f9d Compare October 6, 2023 10:46
@GSadee GSadee merged commit cd1b48b into Sylius:1.13 Oct 6, 2023
25 checks passed
@GSadee
Copy link
Member

GSadee commented Oct 6, 2023

Thanks, Jan! 🎉

@NoResponseMate NoResponseMate deleted the SYL-3110/dedeprecate-apip-service-dependencies branch October 6, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

@Wojdylak Wojdylak Wojdylak approved these changes

@Rafikooo Rafikooo Rafikooo approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NoResponseMate @GSadee @Wojdylak @Rafikooo