Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DX][Checkout][ShippingMethod] Dispatch new ui events #15417

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

Jibbarth
Copy link
Contributor

@Jibbarth Jibbarth commented Oct 7, 2023

Q A
Branch? 1.13
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets N/A
License MIT

Following #15384, this add a sylius.shop.checkout.select_shipping.choice_item_content and a sylius.shop.checkout.select_shipping.choice_item_extra ui events.

Description and fee are now extracted and injected through this new events

@Jibbarth Jibbarth requested a review from a team as a code owner October 7, 2023 07:32
@probot-autolabeler probot-autolabeler bot added the Shop ShopBundle related issues and PRs. label Oct 7, 2023
@github-actions
Copy link

github-actions bot commented Oct 7, 2023

Bunnyshell Preview Environment deployed

It will be automatically stopped in 4 hours.

Use the command /bns:start to start it if it's stopped.

Component Endpoints
mailhog https://mailhog-5ayjvx.bunnyenv.com/
php https://store-5ayjvx.bunnyenv.com/

Available commands:

  • /bns:stop to stop the environment
  • /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

This add a sylius.shop.checkout.select_shipping.choice_item_content and a sylius.shop.checkout.select_shipping.choice_item_extra ui events.
Description and fee are now extracted and injected through this new events
@jakubtobiasz jakubtobiasz force-pushed the feature/ui-event-for-select-shipping branch from 103192d to d9e799e Compare December 21, 2023 10:38
@jakubtobiasz jakubtobiasz self-assigned this Dec 21, 2023
@Jibbarth
Copy link
Contributor Author

Jibbarth commented Feb 5, 2024

@jakubtobiasz Is there anything else i can do here ?

@GSadee GSadee closed this Apr 22, 2024
@GSadee GSadee reopened this Apr 22, 2024
@GSadee GSadee requested a review from a team as a code owner April 22, 2024 13:53
GSadee
GSadee previously approved these changes Apr 23, 2024
@GSadee GSadee merged commit ecb8430 into Sylius:1.13 Apr 23, 2024
4 checks passed
@GSadee
Copy link
Member

GSadee commented Apr 23, 2024

Thank you, Jibé! 🎉

@Jibbarth Jibbarth deleted the feature/ui-event-for-select-shipping branch April 23, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Shop ShopBundle related issues and PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants