Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PostgreSQL] Sylius installation fix #15425

Merged
merged 7 commits into from Oct 11, 2023
Merged

[PostgreSQL] Sylius installation fix #15425

merged 7 commits into from Oct 11, 2023

Conversation

Rafikooo
Copy link
Contributor

Q A
Branch? 1.13
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? yes
Related tickets #15050 #15043 #14950
License MIT

The installation of Sylius 1.13 with PostgreSQL on board ended with the following error:
image
This PR resolves this issue

Second, we removed checking:

if (method_exists($connection, 'createSchemaManager')) {
    return $connection->createSchemaManager();
}

if (method_exists($connection, 'getSchemaManager')) {
    /** @psalm-suppress DeprecatedMethod */
    return $connection->getSchemaManager();
}

as we no longer support doctrine/dbal: 2.x in Sylius 1.13

@Rafikooo Rafikooo added the Bug Confirmed bugs or bugfixes. label Oct 11, 2023
@Rafikooo Rafikooo requested a review from a team as a code owner October 11, 2023 12:24
@probot-autolabeler probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label Oct 11, 2023
@github-actions
Copy link

github-actions bot commented Oct 11, 2023

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

@jakubtobiasz jakubtobiasz merged commit 5c43037 into Sylius:1.13 Oct 11, 2023
25 checks passed
@jakubtobiasz
Copy link
Member

Thank you, @Rafikooo!

GSadee added a commit that referenced this pull request Oct 12, 2023
This PR was merged into the 1.13 branch.

Discussion
----------

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.13 <!-- see the comment below -->                  |
| Bug fix?        | no                                                      |
| New feature?    | no                                                      |
| BC breaks?      | no                                                      |
| Deprecations?   | no<!-- don't forget to update the UPGRADE-*.md file --> |
| License         | MIT                                                          |

Follow up to: #15425

Commits
-------

9a4c74b [CoreBundle] Refactor the constructor of the DatabaseSetupCommandsProvider class
GSadee added a commit to Sylius/SyliusCoreBundle that referenced this pull request Oct 12, 2023
This PR was merged into the 1.13 branch.

Discussion
----------

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.13 <!-- see the comment below -->                  |
| Bug fix?        | no                                                      |
| New feature?    | no                                                      |
| BC breaks?      | no                                                      |
| Deprecations?   | no<!-- don't forget to update the UPGRADE-*.md file --> |
| License         | MIT                                                          |

Follow up to: Sylius/Sylius#15425

Commits
-------

9a4c74b26ade8408d60d727b38e8e0269202c182 [CoreBundle] Refactor the constructor of the DatabaseSetupCommandsProvider class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bugs or bugfixes. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants