[API] Modifying placed order billing & shipping addresses #15532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bunnyshell Preview Environment deletedAvailable commands:
|
diimpp
reviewed
Nov 15, 2023
features/order/managing_orders/modifying_billing_address/modifying_billing_address.feature
Outdated
Show resolved
Hide resolved
...order/managing_orders/modifying_billing_address/modifying_billing_address_validation.feature
Outdated
Show resolved
Hide resolved
src/Sylius/Behat/Resources/config/suites/api/order/modifying_address.yaml
Outdated
Show resolved
Hide resolved
Rafikooo
force-pushed
the
SYL-3224/api-placed-order-address-edit
branch
from
fc59875
to
a61985b
Compare
Rafikooo
changed the title
Rafikooo
force-pushed
the
SYL-3224/api-placed-order-address-edit
branch
3 times, most recently
from
f30cede
to
fb081ae
Compare
Rafikooo
changed the title
Rafikooo
changed the title
Rafikooo
force-pushed
the
SYL-3224/api-placed-order-address-edit
branch
3 times, most recently
from
a475903
to
d1988c0
Compare
Wojdylak
previously approved these changes
Nov 20, 2023
Rafikooo
force-pushed
the
SYL-3224/api-placed-order-address-edit
branch
2 times, most recently
from
d176c3e
to
37a657c
Compare
diimpp
reviewed
Nov 21, 2023
...aging_orders/modifying_billing_address/modifying_billing_address_on_order_with_taxes.feature
Outdated
Show resolved
Hide resolved
Wojdylak
previously approved these changes
Nov 21, 2023
Rafikooo
force-pushed
the
SYL-3224/api-placed-order-address-edit
branch
from
ce50dfa
to
20d7349
Compare
diimpp
previously approved these changes
Nov 21, 2023
jakubtobiasz
previously approved these changes
Nov 21, 2023
| @@ -48,7 +48,7 @@ public function __construct( | |||
| } | |||
|
|
|||
| /** | |||
| * @Given the store ships everything for free within the :zone zone | |||
There was a problem hiding this comment.
It turned out that IDE IntelliSense is case-sensitive and was considering the step as not implemented.
There was a problem hiding this comment.
So I guess we should change the scenario's step 🤔. "Free" with an uppercased letter looks silly here.
There was a problem hiding this comment.
I think that was changed on purpose
GSadee
reviewed
Nov 22, 2023
...der/managing_orders/modifying_shipping_address/modifying_shipping_address_validation.feature
Outdated
Show resolved
Hide resolved
src/Sylius/Behat/Context/Api/Admin/ManagingPlacedOrderAddressesContext.php
Outdated
Show resolved
Hide resolved
src/Sylius/Behat/Context/Api/Admin/ManagingPlacedOrderAddressesContext.php
Outdated
Show resolved
Hide resolved
Rafikooo
dismissed stale reviews from jakubtobiasz, diimpp, and SzymonFilipek
via
e0fcbb3
Rafikooo
force-pushed
the
SYL-3224/api-placed-order-address-edit
branch
from
20d7349
to
e0fcbb3
Compare
Rafikooo
force-pushed
the
SYL-3224/api-placed-order-address-edit
branch
from
e0fcbb3
to
df6ae15
Compare
Rafikooo
force-pushed
the
SYL-3224/api-placed-order-address-edit
branch
from
df6ae15
to
da27211
Compare
Wojdylak
approved these changes
Nov 22, 2023
GSadee
approved these changes
Nov 23, 2023
|
Thanks, Rafał! 🥇 |
NoResponseMate
added a commit
that referenced
this pull request
Dec 5, 2023
…ment Fixes For the New Code (Rafikooo) This PR was merged into the 1.13 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.13 <!-- see the comment below --> | | Bug fix? | no | | New feature? | no | | BC breaks? | no | | Deprecations? | no<!-- don't forget to update the UPGRADE-*.md file --> | | Related tickets | #15532 (comment) | | License | MIT | To save developers' effort during the code review, we added coding standards checks into the unit tests directory as well. Commits ------- [ECS] Add checking in the tests directory [ECS] Apply ecs fixes in the tests directory [ECS] Apply ecs fixes [ECS] Apply another ecs fixes [Behat][UI] Add strong typing in the CartContext class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces API coverage for managing order addresses. However, it also includes some scenarios and UI improvements. Additionally, it introduces a new method for building headers within contract tests.