[API][Admin] Promotion coupons management(CRUD) #15539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NoResponseMate
commented
Nov 17, 2023
NoResponseMate
commented
| Q | A |
|---|---|
| Branch? | 1.13 |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | - |
| License | MIT |
NoResponseMate
added
Feature
Bunnyshell Preview Environment deletedAvailable commands:
|
NoResponseMate
force-pushed
the
SYL-3165/api-managing-coupons
branch
2 times, most recently
from
ca00554
to
2a19a82
Compare
Wojdylak
force-pushed
the
SYL-3165/api-managing-coupons
branch
2 times, most recently
from
c9de8cf
to
1301aad
Compare
Wojdylak
changed the title
Wojdylak
changed the title
Wojdylak
force-pushed
the
SYL-3165/api-managing-coupons
branch
2 times, most recently
from
93e8e36
to
c1b1a27
Compare
GSadee
reviewed
Nov 24, 2023
src/Sylius/Behat/Context/Api/Admin/ManagingPromotionCouponsContext.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/PromotionBundle/Validator/PromotionNotCouponBasedValidator.php
Outdated
Show resolved
Hide resolved
Wojdylak
force-pushed
the
SYL-3165/api-managing-coupons
branch
from
ba59fa7
to
c802381
Compare
Wojdylak
force-pushed
the
SYL-3165/api-managing-coupons
branch
from
ecbfd89
to
c00c016
Compare
Wojdylak
force-pushed
the
SYL-3165/api-managing-coupons
branch
from
c00c016
to
e82780e
Compare
GSadee
approved these changes
Dec 1, 2023
src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/Promotion.xml
Show resolved
Hide resolved
|
Thanks, Jan and Karol! 🥇 |
jakubtobiasz
added a commit
that referenced
this pull request
Dec 6, 2023
This PR was merged into the 1.13 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.13 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | N/A | License | MIT Based on #15539  Commits ------- [ApiBundle] Add generate promotion coupons action [ApiBundle][PromotionCoupon] Add documentation do admin_generate [ApiBundle][Promotion] Add FailedGenerationException to status code mapping [ApiBundle] Remove ObjectDenormalizer [ApiBundle][Promotion] Change subresource operation path [ApiBundle][Promotion] Rename property of GeneratePromotionCoupon [ApiBundle][PromotionCoupon] Flattening structure for coupon generation [ApiBundle][Promotion] Rename group from promotion_coupon:update to promotion_coupon:generate [PromotionBundle] Split PromotionCouponGeneratorInstructionInterface class into separate getter and setter interface [ApiBundle] Change message of PromotionNotFoundException [PromotionBundle] Rename PromotionCouponGeneratorInstructionReadInterface to ReadablePromotionCouponGeneratorInstructionInterface Fixed indentation in PromotionCouponGenerator class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.