Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note to UPGRADE file about introducing TaxonImageRepository #15540

Merged
merged 1 commit into from Nov 17, 2023
Merged

Add note to UPGRADE file about introducing TaxonImageRepository #15540

merged 1 commit into from Nov 17, 2023

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Nov 17, 2023

Q A
Branch? 1.13
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #15504 (review)
License MIT

@GSadee GSadee added the Maintenance CI configurations, READMEs, releases, etc. label Nov 17, 2023
@GSadee GSadee requested a review from a team as a code owner November 17, 2023 13:58
@NoResponseMate NoResponseMate merged commit c1f5dd7 into Sylius:1.13 Nov 17, 2023
2 checks passed
@NoResponseMate
Copy link
Contributor

Thank you, @GSadee!

@GSadee GSadee deleted the taxon-image-repository-upgrade-file branch November 17, 2023 14:03
@GSadee GSadee mentioned this pull request Nov 20, 2023
Merged
NoResponseMate added a commit that referenced this pull request Nov 20, 2023
@NoResponseMate
bugfix #15546 [API][Admin] Revert changing taxon image file (GSadee)
47a23f4 
This PR was merged into the 1.13 branch.

Discussion
----------

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.13|
| Bug fix?        | yes                                                       |
| New feature?    | no                                                      |
| BC breaks?      | no                                                      |
| Deprecations?   | no|
| Related tickets | after #15540 and #15504 |
| License         | MIT                                                          |

As uploading files does not work in PUT requests, I'm reverting the possibility of changing the uploaded file for the existing taxon image. We will try to find a proper solution to this problem in a separate PR.

Ref.:

- https://api-platform.com/docs/core/file-upload/
- symfony/symfony#9226

<!--
 - Bug fixes must be submitted against the 1.12 branch
 - Features and deprecations must be submitted against the 1.13 branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------
  Revert "Add note to UPGRADE file about introducing TaxonImageRepository"
  Revert "[API][Admin] Add possibility to change uploaded taxon image file"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoResponseMate NoResponseMate NoResponseMate approved these changes

Assignees
No one assigned
Labels
Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GSadee @NoResponseMate