Cover "Order details" scenarios in API #15553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jakubtobiasz
commented
Nov 21, 2023
jakubtobiasz
commented
| Q | A |
|---|---|
| Branch? | 1.13 |
| Bug fix? | no |
| New feature? | |
| BC breaks? | no |
| Deprecations? | |
| Related tickets | |
| License | MIT |
jakubtobiasz
changed the title
Bunnyshell Preview Environment deployedIt will be automatically stopped in 4 hours. Use the command
Available commands:
|
jakubtobiasz
force-pushed
the
SYL-3235
branch
from
545c7c8
to
06c75fe
Compare
…s_applied.feature scenarios
…feature scenarios
…s_to_deliver.feature scenarios
Wojdylak
changed the title
NoResponseMate
previously approved these changes
Dec 5, 2023
Comment on lines
233
to
242
| * "@id": string, | ||
| * "@type": string, | ||
| * "variant": string, | ||
| * "productName": string, | ||
| * "id": int, | ||
| * "quantity": int, | ||
| * "unitPrice": int, | ||
| * "originalUnitPrice": int, | ||
| * "total": int, | ||
| * "subtotal": int |
There was a problem hiding this comment.
Suggested change
| * "@id": string, | |
| * "@type": string, | |
| * "variant": string, | |
| * "productName": string, | |
| * "id": int, | |
| * "quantity": int, | |
| * "unitPrice": int, | |
| * "originalUnitPrice": int, | |
| * "total": int, | |
| * "subtotal": int | |
| * "productName": string |
Adding everything seems like an overkill
Comment on lines
317
to
320
| * @Then it should have shipment in state :state | ||
| * @Then /^order "[^"]+" should have shipment state "([^"]+)"$/ | ||
| */ | ||
| public function itShouldHaveShipmentState(string $state): void |
There was a problem hiding this comment.
Suggested change
| * @Then it should have shipment in state :state | |
| * @Then /^order "[^"]+" should have shipment state "([^"]+)"$/ | |
| */ | |
| public function itShouldHaveShipmentState(string $state): void | |
| * @Then /^(it) should have shipment in state "([^"]+)"$/ | |
| * @Then /^(order "[^"]+") should have shipment state "([^"]+)"$/ | |
| */ | |
| public function itShouldHaveShipmentState(OrderInterface $order, string $state): void |
Should work virtually the same since we're getting an order from shared storage either way
TheMilek
previously approved these changes
Dec 5, 2023
Comment on lines
500
to
508
| /** @var OrderInterface $order */ | ||
| $order = $this->sharedStorage->get('order'); | ||
|
|
||
| $adjustments = $this->client->subResourceIndex( | ||
| Resources::ORDERS, | ||
| Resources::ADJUSTMENTS, | ||
| $order->getTokenValue(), | ||
| forgetResponse: true, | ||
| ); |
There was a problem hiding this comment.
I would be after moving it to some private method, as we are using it several times 🤔
Suggested change
| /** @var OrderInterface $order */ | |
| $order = $this->sharedStorage->get('order'); | |
| $adjustments = $this->client->subResourceIndex( | |
| Resources::ORDERS, | |
| Resources::ADJUSTMENTS, | |
| $order->getTokenValue(), | |
| forgetResponse: true, | |
| ); | |
| $adjustments = $this->getAdjustmentsForOrder(); |
GSadee
previously approved these changes
Dec 6, 2023
Comment on lines
475
to
476
| /** @var OrderInterface $order */ | ||
| $order = $this->sharedStorage->get('order'); |
There was a problem hiding this comment.
It can be provided by the transformer
| } | ||
|
|
||
| /** | ||
| * @Then /^its subtotal should be ([^"]+)$/ |
There was a problem hiding this comment.
Suggested change
| * @Then /^its subtotal should be ([^"]+)$/ | |
| * @Then its subtotal should be :subtotal |
Comment on lines
+926
to
+929
| Assert::same( | ||
| $this->responseChecker->getValue($this->client->getLastResponse(), 'payments'), | ||
| [], | ||
| ); |
There was a problem hiding this comment.
Suggested change
| Assert::same( | |
| $this->responseChecker->getValue($this->client->getLastResponse(), 'payments'), | |
| [], | |
| ); | |
| Assert::isEmpty($this->responseChecker->getValue($this->client->getLastResponse(), 'payments')); |
| } | ||
|
|
||
| /** | ||
| * @Then /^the order "[^"]+" should have order shipping state "([^"]+)"$/ |
There was a problem hiding this comment.
This step definition does not fit the arguments, as the order number will be taken as the state
There was a problem hiding this comment.
It won't be as the order number is not between parentheses.
Comment on lines
+951
to
+954
| Assert::same( | ||
| $this->responseChecker->getValue($this->client->getLastResponse(), 'shipments'), | ||
| [], | ||
| ); |
There was a problem hiding this comment.
Suggested change
| Assert::same( | |
| $this->responseChecker->getValue($this->client->getLastResponse(), 'shipments'), | |
| [], | |
| ); | |
| Assert::isEmpty($this->responseChecker->getValue($this->client->getLastResponse(), 'shipments')); |
| foreach ($adjustments as $adjustment) { | ||
| if (in_array($adjustment['order_item_unit']['@id'], $orderItem['units'])) { | ||
| Assert::same($this->getTotalAsInt(trim($price," ~")), $adjustment['amount']); | ||
| return; |
| if ($isMinus) { | ||
| return $amount * -1; | ||
| } | ||
| return $amount; |
There was a problem hiding this comment.
Suggested change
| return $amount; | |
| return $amount; |
Comment on lines
+77
to
+81
| <service id="Sylius\Bundle\ApiBundle\Controller\GetOrderAdjustmentsAction"> | ||
| <argument type="service" id="sylius.repository.order" /> | ||
| <tag name="controller.service_arguments" /> | ||
| </service> | ||
|
|
There was a problem hiding this comment.
It should be added to services/controllers.xml
Wojdylak
dismissed stale reviews from GSadee, TheMilek, and NoResponseMate
via
0fee660
|
Thanks, Jacob! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.