[ECS] Add Code Checking In the Tests Directory and Implement Fixes For the New Code #15558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bunnyshell Preview Environment deletedAvailable commands:
|
diimpp
previously approved these changes
Nov 24, 2023
Wojdylak
previously approved these changes
Nov 24, 2023
|
@Rafikooo can you solve conflicts 😅? |
Rafikooo
force-pushed
the
ecs-in-tests
branch
2 times, most recently
from
c04fa67
to
86f6e2b
Compare
probot-autolabeler
bot
added
the
Maintenance
Rafikooo
force-pushed
the
ecs-in-tests
branch
from
86f6e2b
to
d6bb8a6
Compare
Rafikooo
force-pushed
the
ecs-in-tests
branch
from
d6bb8a6
to
ef3cca4
Compare
Rafikooo
force-pushed
the
ecs-in-tests
branch
2 times, most recently
from
1e3f022
to
152c954
Compare
NoResponseMate
previously approved these changes
Nov 30, 2023
Wojdylak
reviewed
Nov 30, 2023
Rafikooo
force-pushed
the
ecs-in-tests
branch
from
152c954
to
3e391f6
Compare
diimpp
previously approved these changes
Nov 30, 2023
src/Sylius/Bundle/CoreBundle/Validator/Constraints/ChannelCodeCollectionValidator.php
Outdated
Show resolved
Hide resolved
Wojdylak
previously approved these changes
Nov 30, 2023
vvasiloi
previously approved these changes
Dec 1, 2023
Rafikooo
changed the title
Rafikooo
force-pushed
the
ecs-in-tests
branch
from
3e391f6
to
2503a69
Compare
Wojdylak
approved these changes
Dec 5, 2023
NoResponseMate
approved these changes
Dec 5, 2023
|
Thank you, @Rafikooo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To save developers' effort during the code review, we added coding standards checks into the unit tests directory as well.