Cover 'order filtration' scenarios in API #15566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
TheMilek
commented
Nov 28, 2023
TheMilek
commented
| Q | A |
|---|---|
| Branch? | 1.13 |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
Bunnyshell Preview Environment deletedAvailable commands:
|
Wojdylak
approved these changes
Nov 28, 2023
| @@ -17,15 +17,15 @@ Feature: Filtering orders by products | |||
| And the customer chose "Free" shipping method to "United States" with "Offline" payment | |||
| And I am logged in as an administrator | |||
|
|
|||
| @ui @javascript | |||
| @ui @api @javascript | |||
There was a problem hiding this comment.
Can we establish a convention? In the system, we have three variations: @api @ui @javascript, @ui @api @javascript, and @ui @javascript @api. I know it's not a problem of this PR.
Comment on lines
+135
to
+140
| if (str_contains($total, '.')) { | ||
| $total = str_replace('.', '', $total); | ||
| $this->client->addFilter('total[gt]', $total); | ||
|
|
||
| return; | ||
| } |
There was a problem hiding this comment.
I suggest creating a private method that either removes . or adds 00. This method could be used here and method below.
| <tag name="api_platform.filter" /> | ||
| </service> | ||
|
|
||
| <service id="sylius.api.order_product_filter" parent="api_platform.doctrine.orm.search_filter" public="true"> |
There was a problem hiding this comment.
It is only a suggestion to connect all search_filter for order in one filter.
GSadee
approved these changes
Nov 30, 2023
|
|
||
| /** | ||
| * @When I filter by product :productName | ||
| * @When I filter by products :firstProduct and :secondProduct |
There was a problem hiding this comment.
Suggested change
| * @When I filter by products :firstProduct and :secondProduct | |
| * @When I filter by products :firstProductName and :secondProductName |
| * @When I filter by product :productName | ||
| * @When I filter by products :firstProduct and :secondProduct | ||
| */ | ||
| public function iFilterByProduct(string ...$productNames): void |
There was a problem hiding this comment.
Suggested change
| public function iFilterByProduct(string ...$productNames): void | |
| public function iFilterByProduct(string ...$productsNames): void |
|
|
||
| /** | ||
| * @When I filter by variant :variantName | ||
| * @When I filter by variants :firstVariant and :secondVariant |
There was a problem hiding this comment.
Suggested change
| * @When I filter by variants :firstVariant and :secondVariant | |
| * @When I filter by variants :firstVariantName and :secondVariantName |
| /** | ||
| * @Then I should not see an order with :orderNumber number | ||
| */ | ||
| public function iShouldNotSeeOrderWithNumber(string $orderNumber) |
There was a problem hiding this comment.
Suggested change
| public function iShouldNotSeeOrderWithNumber(string $orderNumber) | |
| public function iShouldNotSeeOrderWithNumber(string $orderNumber): void |
|
Thanks, Kamil! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.