Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve psalm issues #15571

Merged
merged 2 commits into from Nov 29, 2023
Merged

Resolve psalm issues #15571

merged 2 commits into from Nov 29, 2023

Conversation

Wojdylak
Copy link
Member

Q A
Branch? 1.12
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets N/A
License MIT

@Wojdylak Wojdylak requested a review from a team as a code owner November 29, 2023 12:57
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 29, 2023 •
edited

Bunnyshell Preview Environment deployment failed

Check https://github.com/Sylius/Sylius/actions/runs/7034417631 for details.

Available commands:

  • /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@Wojdylak Wojdylak added the DX Issues and PRs aimed at improving Developer eXperience. label Nov 29, 2023
jakubtobiasz
jakubtobiasz requested changes Nov 29, 2023
View reviewed changes
phpstan-baseline.neon Show resolved Hide resolved
@jakubtobiasz jakubtobiasz mentioned this pull request Nov 29, 2023
Closed
@Wojdylak Wojdylak force-pushed the fix-ci-112923 branch 2 times, most recently from 20e46fb to 1aa0cde Compare November 29, 2023 14:55
@probot-autolabeler probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label Nov 29, 2023
@Wojdylak Wojdylak removed the Admin AdminBundle related issues and PRs. label Nov 29, 2023
@jakubtobiasz jakubtobiasz merged commit f20d671 into Sylius:1.12 Nov 29, 2023
25 checks passed
@jakubtobiasz
Copy link
Member

Thank you, @Wojdylak!

@Wojdylak Wojdylak deleted the fix-ci-112923 branch November 30, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diimpp diimpp diimpp approved these changes

@jakubtobiasz jakubtobiasz jakubtobiasz approved these changes

Assignees
No one assigned
Labels
DX Issues and PRs aimed at improving Developer eXperience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Wojdylak @jakubtobiasz @diimpp