Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch JS session Behat driver to the Symfony Panther #15617

Merged
merged 5 commits into from Dec 21, 2023
Merged

Switch JS session Behat driver to the Symfony Panther #15617

merged 5 commits into from Dec 21, 2023

Conversation

jakubtobiasz
Copy link
Member

Q A
Branch? 1.12
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets reactivated #13796
License MIT

@jakubtobiasz @loic425
Add a support for Symfony Panther in the JS-based Behats
f7aa75f 
Co-authored-by: Loic Fremont <lc.fremont@gmail.com>
@jakubtobiasz jakubtobiasz added the Maintenance CI configurations, READMEs, releases, etc. label Dec 7, 2023
@jakubtobiasz jakubtobiasz requested a review from a team as a code owner December 7, 2023 16:30
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023 •
edited

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

Prometee
Prometee reviewed Dec 8, 2023
View reviewed changes
behat.yml.dist Outdated Show resolved Hide resolved
@jakubtobiasz jakubtobiasz mentioned this pull request Dec 21, 2023
Closed
@jakubtobiasz jakubtobiasz changed the title 🚧 Switch JS session Behat driver to the Symfony Panther Switch JS session Behat driver to the Symfony Panther Dec 21, 2023
@NoResponseMate NoResponseMate dismissed Prometee’s stale review December 21, 2023 14:21

Will be applied separately

@NoResponseMate NoResponseMate merged commit 6192395 into Sylius:1.12 Dec 21, 2023
25 checks passed
@NoResponseMate
Copy link
Contributor

Thank you, @jakubtobiasz!

@jakubtobiasz jakubtobiasz deleted the hi-panther branch December 21, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prometee Prometee Prometee left review comments

@loic425 loic425 loic425 approved these changes

@NoResponseMate NoResponseMate NoResponseMate approved these changes

Assignees
No one assigned
Labels
Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jakubtobiasz @NoResponseMate @Prometee @loic425