Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #15620

Merged
merged 1 commit into from Dec 8, 2023
Merged

Fix CI #15620

merged 1 commit into from Dec 8, 2023

Conversation

jakubtobiasz
Copy link
Member

Q A
Branch? 1.12
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets n/a
License MIT

In some patch version, Symfony updated the return type for one of the methods to mixed. PHPSpec doesn't support this return type, so I had to return anything manually.

@jakubtobiasz jakubtobiasz added the Maintenance CI configurations, READMEs, releases, etc. label Dec 8, 2023
@jakubtobiasz jakubtobiasz requested a review from a team as a code owner December 8, 2023 07:51
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2023 •
edited

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

@jakubtobiasz jakubtobiasz changed the title [Admin][UI] Fix csrf error breaking admin form Fix CI Dec 8, 2023
@NoResponseMate NoResponseMate merged commit 1367d00 into Sylius:1.12 Dec 8, 2023
25 checks passed
@NoResponseMate
Copy link
Contributor

Thank you, @jakubtobiasz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoResponseMate NoResponseMate NoResponseMate approved these changes

Assignees
No one assigned
Labels
Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jakubtobiasz @NoResponseMate