Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECS] Ordered Types Fixer #15636

Merged
merged 3 commits into from Dec 14, 2023
Merged

[ECS] Ordered Types Fixer #15636

merged 3 commits into from Dec 14, 2023

Conversation

Rafikooo
Copy link
Contributor

@Rafikooo Rafikooo commented Dec 14, 2023 •
edited

Q A
Branch? 1.13
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
License MIT

Let's eliminate another ambiguous convention 馃暫

Reference: #15598 (comment)

Proposal:

  • null at the end
  • the remaining types in alphabetical order

@Rafikooo Rafikooo added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). DX Issues and PRs aimed at improving Developer eXperience. labels Dec 14, 2023
@Rafikooo Rafikooo requested a review from a team as a code owner December 14, 2023 00:24
@probot-autolabeler probot-autolabeler bot added Admin AdminBundle related issues and PRs. API APIs related issues and PRs. labels Dec 14, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 14, 2023 •
edited

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

@Rafikooo Rafikooo changed the title [ECS] Apply ecs fixes [ECS] Ordered Types Fixer Dec 14, 2023
@Rafikooo Rafikooo mentioned this pull request Dec 14, 2023
Merged
@NoResponseMate NoResponseMate merged commit 7ef109a into Sylius:1.13 Dec 14, 2023
25 checks passed
@NoResponseMate
Copy link
Contributor

Thank you, @Rafikooo!

@diimpp
Copy link
Member

diimpp commented Dec 14, 2023

Great addition 馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoResponseMate NoResponseMate NoResponseMate approved these changes

@Wojdylak Wojdylak Wojdylak approved these changes

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs. API APIs related issues and PRs. DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Rafikooo @NoResponseMate @diimpp @Wojdylak