[TestApi] Add new way of assert violations #15695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bunnyshell Preview Environment deletedAvailable commands:
|
NoResponseMate
approved these changes
Jan 4, 2024
|
Thank you, @Wojdylak! |
diimpp
reviewed
Jan 6, 2024
| @@ -155,10 +155,14 @@ public function it_does_not_update_a_shipping_method_with_duplicate_locale_trans | |||
| ], \JSON_THROW_ON_ERROR), | |||
| ); | |||
|
|
|||
| $this->assertResponse( | |||
| $this->assertResponseViolations( | |||
There was a problem hiding this comment.
Feels like I still should be able to specify response code, there at least two codes of 400 and 422 in use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we assert violations by comparing the entire file. This checks not only the violations but also their order. Sometimes, the order is different, causing the test to fail. Therefore, the purpose of this PR is to introduce a new way of asserting violations without checking their order.