Organization of ConsoleCommands/Messages #15730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
Admin
Bunnyshell Preview Environment deletedAvailable commands:
|
Wojdylak
force-pushed
the
SYL-3157-organization-of-api-commands-messages
branch
3 times, most recently
from
8a3b47d
to
ba4f18e
Compare
Wojdylak
force-pushed
the
SYL-3157-organization-of-api-commands-messages
branch
3 times, most recently
from
3421380
to
36c999e
Compare
Wojdylak
changed the title
NoResponseMate
previously approved these changes
Jan 17, 2024
src/Sylius/Bundle/CoreBundle/Console/Command/InformAboutGUSCommand.php
Outdated
Show resolved
Hide resolved
jakubtobiasz
previously approved these changes
Jan 18, 2024
jakubtobiasz
dismissed stale reviews from NoResponseMate and themself
via
19f97c6
jakubtobiasz
force-pushed
the
SYL-3157-organization-of-api-commands-messages
branch
from
36c999e
to
19f97c6
Compare
|
I resolved the conflicts 🖖🏻. |
Wojdylak
force-pushed
the
SYL-3157-organization-of-api-commands-messages
branch
from
19f97c6
to
7bd9755
Compare
diimpp
reviewed
Jan 18, 2024
| <tag name="console.command" /> | ||
| </service> | ||
|
|
||
| <service id="Sylius\Bundle\UserBundle\Command\PromoteUserCommand"> | ||
| <service id="Sylius\Bundle\UserBundle\Command\DemoteUserCommand" alias="Sylius\Bundle\UserBundle\Console\Command\DemoteUserCommand" /> |
There was a problem hiding this comment.
What do you think adding deprecations to the aliases as well?
https://symfony.com/doc/current/service_container/alias_private.html#deprecating-service-aliases
There was a problem hiding this comment.
The files contain information about deprecation, so I think it is enough.
src/Sylius/Bundle/AdminBundle/Tests/Console/Command/CreateAdminUserCommandTest.php
Show resolved
Hide resolved
jakubtobiasz
approved these changes
Jan 18, 2024
NoResponseMate
approved these changes
Jan 18, 2024
|
Thank you, @Wojdylak! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All CLI commands → Console/Command
All Message → Command
List of not released clases:
Due to validation issues (e.g., in
src/Sylius/Bundle/ApiBundle/Resources/config/validation/AdminResetPassword.xml) that do not recognize aliases created on the class, I am unable to move classes from theMessage,MessageDispatcher, andMessageHandlerfolders. I have only added information in the upgrade file that this change will be made in version 2.0.