Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add builds checking whether the frontend can be built with all supported nodejs versions #15746

Merged
merged 1 commit into from Jan 26, 2024
Merged

Add builds checking whether the frontend can be built with all supported nodejs versions #15746

merged 1 commit into from Jan 26, 2024

Conversation

jakubtobiasz
Copy link
Member

Q A
Branch? 1.12
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets n/a
License MIT

@jakubtobiasz jakubtobiasz added the Maintenance CI configurations, READMEs, releases, etc. label Jan 20, 2024
@jakubtobiasz jakubtobiasz requested a review from a team as a code owner January 20, 2024 15:32
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 20, 2024 •
edited

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

@jakubtobiasz jakubtobiasz force-pushed the node-js-ci branch 4 times, most recently from 2981c75 to 4cdb3be Compare January 20, 2024 16:02
@jakubtobiasz
Copy link
Member Author

The frontend CI does a little bit more than just testing the build process of the assets (it reuses the https://github.com/SyliusLabs/BuildTestAppAction), but I don't think it's a big deal. For me, it's better to reuse it than writing it from scratch and maintain it.

@jakubtobiasz jakubtobiasz mentioned this pull request Jan 20, 2024
Closed
@jakubtobiasz @jaroslavtyc
Add builds checking whether the frontend can be built with all suppor…
49e7b73 
…ted nodejs versions

Co-authored-by: jaroslavtyc.com <mail@jaroslavtyc.com>
@NoResponseMate NoResponseMate merged commit adea97c into Sylius:1.12 Jan 26, 2024
27 checks passed
@NoResponseMate
Copy link
Contributor

Thank you, @jakubtobiasz!

@jakubtobiasz jakubtobiasz deleted the node-js-ci branch January 26, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oallain oallain oallain approved these changes

@NoResponseMate NoResponseMate NoResponseMate approved these changes

Assignees
No one assigned
Labels
Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jakubtobiasz @NoResponseMate @oallain