Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ApiBundle] Refactor commands' constructors #15755

Merged
merged 6 commits into from Jan 25, 2024
Merged

[ApiBundle] Refactor commands' constructors #15755

merged 6 commits into from Jan 25, 2024

Conversation

Wojdylak
Copy link
Member

Q A
Branch? 1.13
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets N/A
License MIT

@Wojdylak Wojdylak requested a review from a team as a code owner January 23, 2024 11:40
@probot-autolabeler probot-autolabeler bot added the API APIs related issues and PRs. label Jan 23, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2024 •
edited

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

NoResponseMate
NoResponseMate previously approved these changes Jan 24, 2024
View reviewed changes
GSadee
GSadee reviewed Jan 25, 2024
View reviewed changes
Copy link
Member

@GSadee GSadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to remove respective notes from the UPGRADE-API-1.13 file

@probot-autolabeler probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label Jan 25, 2024
@GSadee GSadee merged commit 2b08d33 into Sylius:1.13 Jan 25, 2024
25 checks passed
@GSadee
Copy link
Member

GSadee commented Jan 25, 2024

Thanks, Karol! 🎉

@Wojdylak Wojdylak deleted the SYL-3291-refactor-commands-constructors branch January 25, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

@NoResponseMate NoResponseMate NoResponseMate left review comments

Assignees
No one assigned
Labels
API APIs related issues and PRs. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Wojdylak @GSadee @NoResponseMate