Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Split read serialization group #15770

Merged
merged 19 commits into from Jan 31, 2024
Merged

Conversation

TheMilek
Copy link
Member

@TheMilek TheMilek commented Jan 26, 2024

Q A
Branch? 1.13
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
License MIT

here is only split of the read group to show and index, in another PR there is a BC layer to handle it

@TheMilek TheMilek added the API APIs related issues and PRs. label Jan 26, 2024
Copy link

github-actions bot commented Jan 26, 2024

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

@TheMilek TheMilek changed the title [WIP] Split read serialization group [API] Split read serialization group Jan 29, 2024
@TheMilek TheMilek marked this pull request as ready for review January 29, 2024 13:18
@TheMilek TheMilek requested a review from a team as a code owner January 29, 2024 13:18
Copy link
Contributor

@Rafikooo Rafikooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some entries in the test code, could be could to get rid of obsolete groups here as well:

<attribute name="groups">foo:read</attribute>

<attribute name="groups">foo-sylius-resource:read</attribute>

And one entry in documentation:

Let's say that you want to change the serialized fields in your responses.

@jakubtobiasz jakubtobiasz merged commit d4cf3b5 into Sylius:1.13 Jan 31, 2024
28 checks passed
@jakubtobiasz
Copy link
Member

Thank you, @TheMilek!

@TheMilek TheMilek deleted the SYL-3292 branch January 31, 2024 10:08
NoResponseMate added a commit that referenced this pull request Jan 31, 2024
…nd :show serialization groups (TheMilek)

This PR was merged into the 1.13 branch.

Discussion
----------

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.13 <!-- see the comment below -->                  |
| Bug fix?        | no                                                      |
| New feature?    | no                                                       |
| BC breaks?      | no                                                       |
| Deprecations?   | yes <!-- don't forget to update the UPGRADE-*.md file --> |
| License         | MIT                                                          |

<!--
 - Bug fixes must be submitted against the 1.12 branch
 - Features and deprecations must be submitted against the 1.13 branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
BC layer for #15770

Commits
-------
  Add BC layer for transition from :read to :index and :show serialization groups
  Add parameters that allow skipping adding read ord index and show serialization groups
  Add information to upgrade file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API APIs related issues and PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants