Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default locale paramter to core #15771

Merged
merged 1 commit into from Jan 29, 2024
Merged

Add default locale paramter to core #15771

merged 1 commit into from Jan 29, 2024

Conversation

TheMilek
Copy link
Member

@TheMilek TheMilek commented Jan 26, 2024 •
edited

Q A
Branch? 1.13
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
License MIT

continuation of #15740
done to prevent exception when locale does not exists in parameters.yaml during installation

@TheMilek TheMilek added the DX Issues and PRs aimed at improving Developer eXperience. label Jan 26, 2024
@TheMilek TheMilek requested a review from a team as a code owner January 26, 2024 11:27
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 26, 2024 •
edited

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

@TheMilek TheMilek force-pushed the SYL-3208-move-parameters-to-another-file branch from 917430f to a3dc54a Compare January 26, 2024 12:16
@TheMilek TheMilek changed the title Move locale parameter definition to _sylius file Add default locale paramter to core Jan 26, 2024
@NoResponseMate NoResponseMate merged commit 9dbd8cd into Sylius:1.13 Jan 29, 2024
25 checks passed
@NoResponseMate
Copy link
Contributor

Thank you, @TheMilek!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oallain oallain oallain approved these changes

@NoResponseMate NoResponseMate NoResponseMate approved these changes

@jakubtobiasz jakubtobiasz jakubtobiasz approved these changes

Assignees
No one assigned
Labels
DX Issues and PRs aimed at improving Developer eXperience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TheMilek @NoResponseMate @oallain @jakubtobiasz