[Emails] Move email managers from Admin and Shop bundles to CoreBundle #15774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GSadee
commented
Jan 26, 2024
GSadee
commented
| Q | A |
|---|---|
| Branch? | 1.13 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Related tickets | |
| License | MIT |
GSadee
added
DX
probot-autolabeler
bot
added
the
Maintenance
Bunnyshell Preview Environment deletedAvailable commands:
|
NoResponseMate
previously approved these changes
Jan 26, 2024
src/Sylius/Bundle/CoreBundle/Mailer/ShipmentEmailManagerInterface.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/AdminBundle/spec/EventListener/ShipmentShipListenerSpec.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ShopBundle/Resources/config/services/email.xml
Outdated
Show resolved
Hide resolved
Wojdylak
previously approved these changes
Jan 29, 2024
src/Sylius/Bundle/ShopBundle/EventListener/OrderCompleteListener.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/AdminBundle/Resources/config/services/email.xml
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/AdminBundle/Resources/config/services/listener.xml
Outdated
Show resolved
Hide resolved
GSadee
force-pushed
the
SYL-3298-deprecate-email-managers
branch
2 times, most recently
from
6ad46ee
to
e2572ba
Compare
...AdminBundle/DependencyInjection/Compiler/BackwardsCompatibility/ReplaceEmailManagersPass.php
Outdated
Show resolved
Hide resolved
...AdminBundle/DependencyInjection/Compiler/BackwardsCompatibility/ReplaceEmailManagersPass.php
Outdated
Show resolved
Hide resolved
.../ShopBundle/DependencyInjection/Compiler/BackwardsCompatibility/ReplaceEmailManagersPass.php
Outdated
Show resolved
Hide resolved
.../ShopBundle/DependencyInjection/Compiler/BackwardsCompatibility/ReplaceEmailManagersPass.php
Outdated
Show resolved
Hide resolved
.../ShopBundle/DependencyInjection/Compiler/BackwardsCompatibility/ReplaceEmailManagersPass.php
Outdated
Show resolved
Hide resolved
...AdminBundle/DependencyInjection/Compiler/BackwardsCompatibility/ReplaceEmailManagersPass.php
Outdated
Show resolved
Hide resolved
GSadee
force-pushed
the
SYL-3298-deprecate-email-managers
branch
from
d20b8c4
to
448a428
Compare
GSadee
force-pushed
the
SYL-3298-deprecate-email-managers
branch
from
448a428
to
3038c3e
Compare
NoResponseMate
approved these changes
Feb 2, 2024
Rafikooo
approved these changes
Feb 2, 2024
|
Thank you, @GSadee! |
jakubtobiasz
added a commit
that referenced
this pull request
Feb 14, 2024
This PR was merged into the 1.13 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.13 <!-- see the comment below --> | | Bug fix? | no | | New feature? | no | | BC breaks? | no | | Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file --> | | Related tickets | #15774 | | License | MIT | <!-- - Bug fixes must be submitted against the 1.12 branch - Features and deprecations must be submitted against the 1.13 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- [Admin] Deprecate ShipmentEmailManager and its interface [Shop] Deprecate ContactEmailManager and its interface Minor improvements for ShipmentEmailManager Extract reset password email sending to a dedicated manager Extract account registration email sending to a dedicated manager Extract account verification email sending to a dedicated manager Use OrderEmailManager in SendOrderConfirmationHandler Use ShipmentEmailManager in SendShipmentConfirmationHandler Remove obsolete functional tests Use ContactEmailManager in SendContactRequestHandler [ECS] Apply ecs fixes Move shop part of account verification template [Upgrade] Mention constructor changes in command handlers Unify account verification template naming in Shop and Core bundles [Email] Move e-mail sending from SendResetPasswordEmailHandler into ResetPasswordEmailManager [ApiBundle] Include resource objects checks in the SendAccountVerificationEmailHandler [Test] Move isSwiftmailerTestEnv helper function into trait [Email] Change verification email subject path [Test] Remove swiftmailer test [Test] Use new user verification message id [Email] Change translation keys regarding user account verification [CoreBundle] Add aliases to the new mailer services [Refactor] Place the EmailManager construct arguments after the repository arguments within command handler classes Update upgrade api file Update upgrade file
GSadee
pushed a commit
to Sylius/SyliusApiBundle
that referenced
this pull request
Mar 11, 2024
This PR was merged into the 1.13 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.13 <!-- see the comment below --> | | Bug fix? | no | | New feature? | no | | BC breaks? | no | | Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file --> | | Related tickets | Sylius/Sylius#15774 | | License | MIT | <!-- - Bug fixes must be submitted against the 1.12 branch - Features and deprecations must be submitted against the 1.13 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- [Admin] Deprecate ShipmentEmailManager and its interface [Shop] Deprecate ContactEmailManager and its interface Minor improvements for ShipmentEmailManager Extract reset password email sending to a dedicated manager Extract account registration email sending to a dedicated manager Extract account verification email sending to a dedicated manager Use OrderEmailManager in SendOrderConfirmationHandler Use ShipmentEmailManager in SendShipmentConfirmationHandler Remove obsolete functional tests Use ContactEmailManager in SendContactRequestHandler [ECS] Apply ecs fixes Move shop part of account verification template [Upgrade] Mention constructor changes in command handlers Unify account verification template naming in Shop and Core bundles [Email] Move e-mail sending from SendResetPasswordEmailHandler into ResetPasswordEmailManager [ApiBundle] Include resource objects checks in the SendAccountVerificationEmailHandler [Test] Move isSwiftmailerTestEnv helper function into trait [Email] Change verification email subject path [Test] Remove swiftmailer test [Test] Use new user verification message id [Email] Change translation keys regarding user account verification [CoreBundle] Add aliases to the new mailer services [Refactor] Place the EmailManager construct arguments after the repository arguments within command handler classes Update upgrade api file Update upgrade file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.