Usage of E-Mail Managers within CommandHandlers #15794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Rafikooo
commented
Feb 1, 2024
Rafikooo
commented
| Q | A |
|---|---|
| Branch? | 1.13 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | #15774 |
| License | MIT |
Rafikooo
added
DX
probot-autolabeler
bot
added
Admin
Rafikooo
force-pushed
the
SYL-3299/email-manager-command-handlers
branch
from
c9ea89e
to
4d1ed66
Compare
Bunnyshell Preview Environment deletedAvailable commands:
|
Rafikooo
force-pushed
the
SYL-3299/email-manager-command-handlers
branch
from
4d1ed66
to
de746d6
Compare
Wojdylak
previously approved these changes
Feb 2, 2024
Rafikooo
force-pushed
the
SYL-3299/email-manager-command-handlers
branch
from
de746d6
to
e419871
Compare
Rafikooo
changed the title
Rafikooo
force-pushed
the
SYL-3299/email-manager-command-handlers
branch
2 times, most recently
from
d0f9604
to
270d74b
Compare
Rafikooo
changed the title
Rafikooo
force-pushed
the
SYL-3299/email-manager-command-handlers
branch
6 times, most recently
from
e4cbf85
to
c3e0d57
Compare
src/Sylius/Bundle/ApiBundle/CommandHandler/SendContactRequestHandler.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Mailer/ResetPasswordEmailManager.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Resources/config/app/sylius/sylius_mailer.yml
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Resources/views/Email/accountVerification.html.twig
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Tests/Mailer/AccountRegistrationEmailManagerTest.php
Outdated
Show resolved
Hide resolved
Rafikooo
force-pushed
the
SYL-3299/email-manager-command-handlers
branch
5 times, most recently
from
bb1ff3c
to
e2569de
Compare
Wojdylak
previously approved these changes
Feb 12, 2024
...ius/Bundle/ApiBundle/spec/CommandHandler/Account/SendAccountRegistrationEmailHandlerSpec.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Tests/Mailer/AccountVerificationEmailManagerTest.php
Outdated
Show resolved
Hide resolved
…esetPasswordEmailManager
…ationEmailHandler
…itory arguments within command handler classes
Rafikooo
force-pushed
the
SYL-3299/email-manager-command-handlers
branch
from
793df91
to
ef2b428
Compare
src/Sylius/Bundle/ApiBundle/CommandHandler/Checkout/SendOrderConfirmationHandler.php
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/CommandHandler/SendContactRequestHandler.php
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/CommandHandler/SendContactRequestHandler.php
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Resources/config/app/sylius/sylius_mailer.yml
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Resources/config/services/mailer.xml
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Resources/views/Email/accountVerification.html.twig
Show resolved
Hide resolved
Comment on lines
+49
to
+60
| <service id="sylius.mailer.account_registration_email_manager" | ||
| class="Sylius\Bundle\CoreBundle\Mailer\AccountRegistrationEmailManager" | ||
| > | ||
| <argument type="service" id="sylius.email_sender" /> | ||
| </service> | ||
| <service id="Sylius\Bundle\CoreBundle\Mailer\AccountRegistrationEmailManagerInterface" alias="sylius.mailer.account_registration_email_manager" /> | ||
|
|
||
| <service id="sylius.mailer.account_verification_email_manager" | ||
| class="Sylius\Bundle\CoreBundle\Mailer\AccountVerificationEmailManager" | ||
| > | ||
| <argument type="service" id="sylius.email_sender" /> | ||
| </service> |
There was a problem hiding this comment.
It's minor but if you don't forget – inline id with class in a separate PR
There was a problem hiding this comment.
ok, I didn't check the others :|
jakubtobiasz
approved these changes
Feb 14, 2024
|
Thank you, @Rafikooo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.