Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API][Shop] Add missing contract test for getting only countries from current channel #15872

Merged
merged 1 commit into from Feb 23, 2024
Merged

[API][Shop] Add missing contract test for getting only countries from current channel #15872

merged 1 commit into from Feb 23, 2024
+72 −0

Conversation

GSadee
Copy link
Member

@GSadee GSadee commented Feb 23, 2024

Q A
Branch? 1.13
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets Based on #15871
License MIT

@GSadee GSadee added the API APIs related issues and PRs. label Feb 23, 2024
@GSadee GSadee requested a review from a team as a code owner February 23, 2024 09:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 23, 2024 •
edited

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

@GSadee GSadee mentioned this pull request Feb 23, 2024
Merged
@NoResponseMate NoResponseMate merged commit 5d825a9 into Sylius:1.13 Feb 23, 2024
28 checks passed
@NoResponseMate
Copy link
Contributor

Thank you, @GSadee!

NoResponseMate added a commit that referenced this pull request Feb 23, 2024
@NoResponseMate
minor #15873 [API][Shop] Add missing contract test for getting only l…
eebc66b 
…ocales from current channel (GSadee)

This PR was merged into the 1.13 branch.

Discussion
----------



| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.13|
| Bug fix?        | no                                                      |
| New feature?    | no                                                      |
| BC breaks?      | no                                                      |
| Deprecations?   | no<!-- don't forget to update the UPGRADE-*.md file --> |
| Related tickets | related to #15872 |
| License         | MIT                                                          |

<!--
 - Bug fixes must be submitted against the 1.12 branch
 - Features and deprecations must be submitted against the 1.13 branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------
  [API][Shop] Add missing contract test for getting only locales from current channel
@GSadee GSadee deleted the api-country-tests-cleanup branch February 26, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoResponseMate NoResponseMate NoResponseMate approved these changes

@jakubtobiasz jakubtobiasz jakubtobiasz approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GSadee @NoResponseMate @jakubtobiasz