Replace DC2TYPE:array field types with JSON #16008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
TheMilek
commented
Mar 15, 2024
•
TheMilek
commented
| Q | A |
|---|---|
| Branch? | 1.13 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Related tickets | fixes #9399 |
| License | MIT |
TheMilek
added
the
Enhancement
probot-autolabeler
bot
added
the
Maintenance
Bunnyshell Preview Environment deletedAvailable commands:
|
TheMilek
force-pushed
the
SYL-2874
branch
7 times, most recently
from
438b422
to
c0d4e19
Compare
jakubtobiasz
previously approved these changes
Mar 18, 2024
| @@ -22,7 +22,7 @@ | |||
| <field name="objectId" column="object_id" length="64" nullable="true" /> | |||
| <field name="objectClass" column="object_class" type="string" /> | |||
| <field name="version" column="version" type="integer" /> | |||
| <field name="data" column="data" type="array" /> | |||
There was a problem hiding this comment.
I guess it was done to match original mapping
but I don't think it makes sense to do so at this stage.
Suggested change
| <field name="data" column="data" type="array" /> | |
| <field name="data" column="data" type="json" /> |
There was a problem hiding this comment.
I need to leave this change, as without it the removal of address'es is not working
There was a problem hiding this comment.
Strange, that it worked before.
What do you think mentioning this change in changelog, if it's necessary?
diimpp
requested changes
Mar 18, 2024
src/Sylius/Bundle/CoreBundle/Migrations/Version20240315112656.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Migrations/Version20240315112656.php
Outdated
Show resolved
Hide resolved
| @@ -22,7 +22,7 @@ | |||
| <field name="objectId" column="object_id" length="64" nullable="true" /> | |||
| <field name="objectClass" column="object_class" type="string" /> | |||
| <field name="version" column="version" type="integer" /> | |||
| <field name="data" column="data" type="array" /> | |||
There was a problem hiding this comment.
I guess it was done to match original mapping
but I don't think it makes sense to do so at this stage.
Suggested change
| <field name="data" column="data" type="array" /> | |
| <field name="data" column="data" type="json" /> |
TheMilek
force-pushed
the
SYL-2874
branch
4 times, most recently
from
796a7c4
to
252141f
Compare
NoResponseMate
previously approved these changes
Mar 20, 2024
diimpp
previously approved these changes
Mar 20, 2024
| @@ -22,7 +22,7 @@ | |||
| <field name="objectId" column="object_id" length="64" nullable="true" /> | |||
| <field name="objectClass" column="object_class" type="string" /> | |||
| <field name="version" column="version" type="integer" /> | |||
| <field name="data" column="data" type="array" /> | |||
There was a problem hiding this comment.
Strange, that it worked before.
What do you think mentioning this change in changelog, if it's necessary?
NoResponseMate
approved these changes
Mar 21, 2024
Wojdylak
approved these changes
Mar 21, 2024
|
Thank you, @TheMilek! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.