Implement Shipping Method Index/Create/Update pages #16129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bunnyshell Preview Environment deletedAvailable commands:
|
jakubtobiasz
force-pushed
the
bap/SYL-3203-shipping-methods
branch
from
5f1885f
to
2f734f5
Compare
mpysiak
approved these changes
Apr 22, 2024
jakubtobiasz
force-pushed
the
bap/SYL-3203-shipping-methods
branch
2 times, most recently
from
d9d0767
to
b617846
Compare
|
/bns:start |
Wojdylak
reviewed
Apr 24, 2024
src/Sylius/Bundle/AdminBundle/Resources/views/Shared/form_theme.html.twig
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/AdminBundle/Resources/views/Shared/form_theme.html.twig
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/AdminBundle/Resources/views/Shared/form_theme.html.twig
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ShippingBundle/Form/Type/ShippingMethodType.php
Outdated
Show resolved
Hide resolved
Wojdylak
reviewed
Apr 24, 2024
src/Sylius/Bundle/AdminBundle/TwigComponent/ShippingMethod/FormComponent.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/AdminBundle/Resources/views/Shared/form_theme.html.twig
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/AdminBundle/Resources/views/ShippingMethod/form.html.twig
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ShippingBundle/Form/Type/ShippingMethodRuleCollectionType.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ShippingBundle/Resources/config/services/form.xml
Outdated
Show resolved
Hide resolved
Wojdylak
force-pushed
the
bap/SYL-3203-shipping-methods
branch
from
9d8dad7
to
38a939d
Compare
GSadee
reviewed
Apr 29, 2024
src/Sylius/Behat/Context/Api/Admin/ManagingShippingMethodsContext.php
Outdated
Show resolved
Hide resolved
src/Sylius/Behat/Context/Ui/Admin/ManagingShippingMethodsContext.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/AdminBundle/Resources/config/services/form.xml
Outdated
Show resolved
Hide resolved
GSadee
approved these changes
Apr 29, 2024
…rs.feature scenarios
… in the form element
Wojdylak
force-pushed
the
bap/SYL-3203-shipping-methods
branch
from
5098eb6
to
3f77aef
Compare
GSadee
approved these changes
May 7, 2024
| public function __construct( | ||
| private IndexPageInterface $indexPage, | ||
| private CreatePageInterface $createPage, | ||
| private UpdatePageInterface $updatePage, | ||
| private CurrentPageResolverInterface $currentPageResolver, | ||
| private NotificationCheckerInterface $notificationChecker, | ||
| private FormElementInterface $shippingMethodFormElement, |
There was a problem hiding this comment.
Suggested change
| private FormElementInterface $shippingMethodFormElement, | |
| private FormElementInterface $formElement, |
🤔
| /** | ||
| * @Then I should be notified that name is required | ||
| */ | ||
| public function iShouldBeNotifiedThatNameIsRequired($localeCode = 'en_US'): void |
There was a problem hiding this comment.
Suggested change
| public function iShouldBeNotifiedThatNameIsRequired($localeCode = 'en_US'): void | |
| public function iShouldBeNotifiedThatNameIsRequired(string $localeCode = 'en_US'): void |
| } | ||
|
|
||
| /** | ||
| * @Then I should be notified that name is required |
There was a problem hiding this comment.
Then methods should be after When ones
| use Sylius\Behat\Service\DriverHelper; | ||
| use Sylius\Behat\Service\TabsHelper; | ||
| use Sylius\Component\Core\Formatter\StringInflector; | ||
| use Webmozart\Assert\Assert; | ||
|
|
||
| class CreatePage extends BaseCreatePage implements CreatePageInterface |
There was a problem hiding this comment.
Both CreatePage and UpdatePage for shipping method could be probably removed as they are empty now
| <tag name="form.type_extension" /> | ||
| </service> | ||
|
|
||
| <service id="sylius.form.extension.shipping_method_rule" class="Sylius\Bundle\AdminBundle\Form\Extension\ShippingMethodRuleTypeExtension"> |
There was a problem hiding this comment.
Suggested change
| <service id="sylius.form.extension.shipping_method_rule" class="Sylius\Bundle\AdminBundle\Form\Extension\ShippingMethodRuleTypeExtension"> | |
| <service id="sylius_admin.form.extension.shipping_method_rule" class="Sylius\Bundle\AdminBundle\Form\Extension\ShippingMethodRuleTypeExtension"> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bootstrap-admin-panel