[Admin][Product] Add generate variants page #16162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Wojdylak
commented
Apr 22, 2024
•
Wojdylak
commented
| Q | A |
|---|---|
| Branch? | bootstrap-admin-panel |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | N/A |
| License | MIT |
Wojdylak
force-pushed
the
SYL-3436-product-variants-generation-page
branch
from
e7973d2
to
53f8825
Compare
Bunnyshell Preview Environment deletedAvailable commands:
|
mpysiak
reviewed
Apr 23, 2024
...us/Bundle/AdminBundle/Resources/views/Product/generate_variants/header/breadcrumbs.html.twig
Outdated
Show resolved
Hide resolved
Rafikooo
reviewed
Apr 23, 2024
src/Sylius/Bundle/AdminBundle/Resources/views/Product/generate_variants/form/variants.html.twig
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/AdminBundle/Twig/Component/Product/GenerateVariantsFormComponent.php
Outdated
Show resolved
Hide resolved
Wojdylak
force-pushed
the
SYL-3436-product-variants-generation-page
branch
from
18c30d1
to
438d769
Compare
mpysiak
approved these changes
Apr 24, 2024
TheMilek
approved these changes
Apr 24, 2024
src/Sylius/Bundle/AdminBundle/Resources/config/app/twig_hooks/product/generate_variants.yaml
Show resolved
Hide resolved
|
/bns:start |
|
I would maybe only change the |
Rafikooo
approved these changes
Apr 24, 2024
src/Sylius/Bundle/AdminBundle/Twig/Component/Product/GenerateVariantsFormComponent.php
Outdated
Show resolved
Hide resolved
Wojdylak
force-pushed
the
SYL-3436-product-variants-generation-page
branch
from
438d769
to
9cf22a2
Compare
…uctVariantsFormComponent
Comment on lines
-92
to
-109
| sylius_admin_product_variant_generate: | ||
| path: /generate | ||
| methods: [GET, POST] | ||
| defaults: | ||
| _controller: sylius.controller.product::updateAction | ||
| _sylius: | ||
| template: "@SyliusAdmin/ProductVariant/generate.html.twig" | ||
| section: admin | ||
| permission: true | ||
| redirect: | ||
| route: sylius_admin_product_variant_index | ||
| parameters: { productId: $productId } | ||
| form: | ||
| type: Sylius\Bundle\ProductBundle\Form\Type\ProductGenerateVariantsType | ||
| repository: | ||
| method: find | ||
| arguments: [$productId] | ||
| flash: sylius.product_variant.generate |
| {% set fallback_hook = hook_name(parent_fallback_hook, 'form') %} | ||
|
|
||
| <div class="container-xl" {{ attributes }}> | ||
| {{ form_start(form, {'attr': {'class': 'ui loadable form', 'novalidate': 'novalidate', 'id': form.vars.id}}) }} |
There was a problem hiding this comment.
Suggested change
| {{ form_start(form, {'attr': {'class': 'ui loadable form', 'novalidate': 'novalidate', 'id': form.vars.id}}) }} | |
| {{ form_start(form, {'attr': {'novalidate': 'novalidate'}}) }} |
Do we even need theses 2?
Comment on lines
+7
to
+11
| <div> | ||
| {% for optionValue in form.optionValues %} | ||
| {{ optionValue.vars.label|trans }}: <span class="fw-bold me-1">{{ optionValue.vars.value }}</span> | ||
| {% endfor %} | ||
| </div> |
There was a problem hiding this comment.
Would be nice to check how that'd look with a lot of options
GSadee
approved these changes
Apr 25, 2024
Comment on lines
+81
to
+85
| 'generate_button' => '[data-test-generate-button]', | ||
| 'delete_button' => '#sylius_product_generate_variants_variants_%position% [data-test-delete-button]', | ||
| 'code' => '#sylius_product_generate_variants_variants_%position% [data-test-code]', | ||
| 'channel_pricings' => '#sylius_product_generate_variants_variants_%position% [data-test-channel-pricings]', | ||
| 'form' => '[data-live-name-value="sylius_admin:product:generate_product_variants_form"]', |
There was a problem hiding this comment.
Keys should be in alphabetical order
Comment on lines
+66
to
+67
|
|
||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.