Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare a PoC of Twig Components for the Sylius UI #16229

Closed

Conversation

jakubtobiasz
Copy link
Contributor

The idea is to create a set of Twig Components, so we can create a button with

<twig:sylius_ui:button>Click me!</twig>

or a submit button with

<twig:sylius_ui:button:submit>Create a product</twig>

Why?

  • Next step towards composable layouts
  • If someone one day decide to switch to e.g. Tailwind or any other CSS framework we have an abstraction over the components. It should also be easier to provide a custom CSS framework :)
  • We can create a components library

Known issues:

  • To adopt it widely in Sylius we need a reasonable way to pass data-test attributes, as currently trying to use {{ sylius_test_html_attribute('...') }} results in an error

Copy link

github-actions bot commented May 7, 2024

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

@GSadee GSadee changed the base branch from bootstrap-admin-panel to 2.0 May 20, 2024 09:30
@GSadee
Copy link
Member

GSadee commented May 20, 2024

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "bap/sylius-ui-components" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@Wojdylak
Copy link
Member

This has been done in this PR #16394

@Wojdylak Wojdylak closed this Jun 18, 2024
@jakubtobiasz jakubtobiasz deleted the bap/sylius-ui-components branch June 18, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants