Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wider support for deprecation contract #16233

Merged
merged 1 commit into from
May 10, 2024

Conversation

Jibbarth
Copy link
Contributor

@Jibbarth Jibbarth commented May 8, 2024

Q A
Branch? 1.13
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets N/A
License MIT

Hello,

I wanted to add a library, but I got stuck with the deprecation-contract, the library I wanted only accept ^3.0

As we can see on the diff, there is not so much change between the two version.

I think we can add that version too without changing anything else.

Tell me if I should target 1.12 instead.

Thanks

@Jibbarth Jibbarth requested review from a team as code owners May 8, 2024 08:46
@Jibbarth Jibbarth changed the base branch from 1.14 to 1.13 May 8, 2024 08:49
Copy link

github-actions bot commented May 8, 2024

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

@GSadee GSadee added the Dependencies Pull requests that update a dependency file label May 10, 2024
@GSadee GSadee merged commit a504048 into Sylius:1.13 May 10, 2024
28 checks passed
@GSadee
Copy link
Member

GSadee commented May 10, 2024

Thank you, Jibé! 🥇

@Jibbarth Jibbarth deleted the feature/deprecation-contract branch May 10, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants