[Admin] Add base form type for every resource used in AdminBundle #16276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMilek
force-pushed
the
SYL-3520-add-form-types-for-every-resource
branch
from
82057a4
to
c054d1d
Compare
probot-autolabeler
bot
added
the
Maintenance
Bunnyshell Preview Environment deletedAvailable commands:
|
TheMilek
force-pushed
the
SYL-3520-add-form-types-for-every-resource
branch
10 times, most recently
from
6d03fd5
to
c09961a
Compare
Wojdylak
previously approved these changes
May 21, 2024
mpysiak
previously approved these changes
May 21, 2024
GSadee
reviewed
May 21, 2024
There was a problem hiding this comment.
Since we are based on form types for resources, I would also think about:
- AvatarImageType
- ChannelPriceHistoryConfigType
- ChannelPricingType
- GatewayConfigType
- ProductAssociationType
- ProductAttributeTranslationType
- ProductImageType
- ProductOptionTranslationType
- ProductTranslationType
- ProductVariantTranslationType
- ProvinceType
- ShopBillingDataType
- TaxonImageType
- TaxonTranslationType
- ZoneMemberType
src/Sylius/Bundle/AdminBundle/Form/Type/CatalogPromotionType.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/AdminBundle/Resources/config/services/form.xml
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/AdminBundle/Resources/config/services/form.xml
Outdated
Show resolved
Hide resolved
TheMilek
force-pushed
the
SYL-3520-add-form-types-for-every-resource
branch
from
c09961a
to
2106972
Compare
TheMilek
force-pushed
the
SYL-3520-add-form-types-for-every-resource
branch
from
2106972
to
d57118b
Compare
GSadee
approved these changes
May 22, 2024
|
Thank you, Kamil! 🥇 |
NoResponseMate
added a commit
that referenced
this pull request
May 22, 2024
This PR was merged into the 1.14 branch. Discussion ---------- | Q | A |-----------------|----- | Branch? | 1.14 <!-- see the comment below --> | Bug fix? | no | New feature? | no | BC breaks? | no | License | MIT <!-- - Bug fixes must be submitted against the 1.12 or 1.13 branches - Features and deprecations must be submitted against the 1.14 branch - Features, removing deprecations and BC breaks must be submitted against the 2.0 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> continuation of #16276 Commits ------- Add missing ShipmentShipType to AdminBundle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #16257