Improve Order get endpoints #16321
Merged
Improve Order get endpoints #16321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
TheMilek
commented
May 29, 2024
TheMilek
commented
| Q | A |
|---|---|
| Branch? | 1.12 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| License | MIT |
TheMilek
added
Shop
TheMilek
changed the title
Bunnyshell Preview Environment deletedAvailable commands:
|
TheMilek
force-pushed
the
SYL-3542-improve-order-get-endpoints
branch
from
801d39a
to
bb3cc9d
Compare
TheMilek
force-pushed
the
SYL-3542-improve-order-get-endpoints
branch
2 times, most recently
from
ca27091
to
3d42fd4
Compare
| } | ||
|
|
||
| /** @test */ | ||
| public function it_gets_order_item_adjustments(): void |
There was a problem hiding this comment.
Since we already have a split in the actions between the user/visitor, maybe we should also duplicate all the other tests in this file per case.
src/Sylius/Bundle/ApiBundle/DataProvider/OrderAdjustmentsSubresourceDataProvider.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Resources/config/services/security.xml
Outdated
Show resolved
Hide resolved
...romotion/receiving_discount/receiving_discounts_with_product_minimum_price_specified.feature
Show resolved
Hide resolved
TheMilek
force-pushed
the
SYL-3542-improve-order-get-endpoints
branch
from
3d42fd4
to
fe653b7
Compare
TheMilek
force-pushed
the
SYL-3542-improve-order-get-endpoints
branch
from
fe653b7
to
5bba8f0
Compare
GSadee
approved these changes
Jun 6, 2024
| xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd" | ||
| > | ||
| <services> | ||
| <service id="sylius_api.security.voter.order" class="Sylius\Bundle\ApiBundle\Security\OrderAdjustmentsVoter"> |
There was a problem hiding this comment.
Suggested change
| <service id="sylius_api.security.voter.order" class="Sylius\Bundle\ApiBundle\Security\OrderAdjustmentsVoter"> | |
| <service id="sylius_api.security.voter.order_adjustments" class="Sylius\Bundle\ApiBundle\Security\OrderAdjustmentsVoter"> |
Comment on lines
+51
to
+53
| if ($this->adjustmentOrderProvider->provide($subjectItem)) { | ||
| /** @var OrderInterface $order */ | ||
| $order = $this->adjustmentOrderProvider->provide($subjectItem); |
There was a problem hiding this comment.
Suggested change
| if ($this->adjustmentOrderProvider->provide($subjectItem)) { | |
| /** @var OrderInterface $order */ | |
| $order = $this->adjustmentOrderProvider->provide($subjectItem); | |
| $order = $this->adjustmentOrderProvider->provide($subjectItem); | |
| if ($order !== null) { |
|
Thank you, Kamil! 🥇 |
NoResponseMate
added a commit
that referenced
this pull request
Jun 7, 2024
…Sadee) This PR was merged into the 1.13 branch. Discussion ---------- | Q | A |-----------------|----- | Branch? | 1.13 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no<!-- don't forget to update the UPGRADE-*.md file --> | Related tickets | after upmerge of #16321 | License | MIT <!-- - Bug fixes must be submitted against the 1.12 or 1.13 branches - Features and deprecations must be submitted against the 1.14 branch - Features, removing deprecations and BC breaks must be submitted against the 2.0 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- [API] Adjust adjustments contract tests after upmerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.