Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve createdByGuest on order fixtures #16342

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

TheMilek
Copy link
Member

@TheMilek TheMilek commented Jun 4, 2024

Q A
Branch? 1.12
Bug fix? a bit
New feature? no
BC breaks? no
License MIT

@TheMilek TheMilek added the DX Issues and PRs aimed at improving Developer eXperience. label Jun 4, 2024
@TheMilek TheMilek requested review from a team as code owners June 4, 2024 11:18
Copy link

github-actions bot commented Jun 4, 2024

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

@TheMilek TheMilek changed the base branch from 1.14 to 1.12 June 4, 2024 12:12
Comment on lines +80 to +82
$customer = $order->getCustomer();

if ($customer->hasUser()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$customer = $order->getCustomer();
if ($customer->hasUser()) {
$customer = $order->getCustomer();
if ($customer->hasUser()) {

@GSadee GSadee merged commit 3865509 into Sylius:1.12 Jun 6, 2024
28 checks passed
@GSadee
Copy link
Member

GSadee commented Jun 6, 2024

Thank you, Kamil! 🥇

@TheMilek TheMilek deleted the SYL-3542-fix-order-fixtures branch June 6, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Issues and PRs aimed at improving Developer eXperience.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants