Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User] Update the default tokens' length and the upper limit #16393

Conversation

NoResponseMate
Copy link
Contributor

Q A
Branch? 1.12
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets replaces #16383
License MIT

@NoResponseMate NoResponseMate added the Bug Confirmed bugs or bugfixes. label Jun 13, 2024
@NoResponseMate NoResponseMate requested review from a team as code owners June 13, 2024 07:19
@probot-autolabeler probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label Jun 13, 2024
Copy link

github-actions bot commented Jun 13, 2024

Bunnyshell Preview Environment deleted

Available commands:

  • /bns:deploy to redeploy the environment

@GSadee GSadee merged commit 2b58e01 into Sylius:1.12 Jun 14, 2024
53 of 56 checks passed
@GSadee
Copy link
Member

GSadee commented Jun 14, 2024

Thanks, Jan! 🎉

Wojdylak added a commit that referenced this pull request Jun 18, 2024
…Tests (Rafikooo)

This PR was merged into the 1.13 branch.

Discussion
----------

| Q               | A
|-----------------|-----
| Branch?         | 1.13 <!-- see the comment below -->
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no <!-- don't forget to update the UPGRADE-*.md file -->
| Related tickets | #16393 https://github.com/Sylius/Sylius/pull/16393/files#diff-2457b8aae3ac4bde24b495649d257987a0d616a1b6aa945c94f7764ab7387c40R69
| License         | MIT

The aforementioned PR has been merged into version `1.12`. In `1.13`, we added a package test to verify the token length. This PR reflects that updated default value.

Commits
-------
  [User] Reflect new default token length in the ConfigurationTest class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bugs or bugfixes. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants