Order Transition on confirm does not make sense.

[liverbool]

https://github.com/Sylius/Sylius/blob/master/src/Sylius/Bundle/CoreBundle/Resources/config/state-machine.yml#L85

    sylius_order:
        callbacks:
            after:
                ...
                sylius_update_shipment:
                    on:   'confirm'
                    do:   [@sm.callback.cascade_transition, 'apply']
                    args: ['object.getShipments()', 'event', '"prepare"', '"sylius_shipment"']

This transition will make shipment's state to ready. I think it does not make sense because some case order's state can be backorder,... So shipment's state should not be ready in this case.

ping @stloyd

[stloyd]

Hmmm, in fact it sounds quite reasonable, but I'm not the author (ping @winzou) of that callback so I can't say why it was that way.

@Arn0d @pjedrzejewski do you remember reason of that callback?

[kayue]

@liverbool Do you think you can do a before callback on prepare transition, and switch "ready" to "backorder"?

If this is not possible then we must do it via a separated callback.

Sylius/src/Sylius/Bundle/ShippingBundle/Resources/config/state-machine.yml

Lines 23 to 25 in 1e040af

	prepare:
	from: [checkout, onhold]
	to: ready

[liverbool]

@kayue i think before not a good choice to use, the sylius_update_shipment task should have to change callback service to do this job.
Do you think?

[kayue]

Make sense to me 👍

[liverbool]

PR #2045

[winzou]

👍