Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC][ResourceBundle] Missing list, show events for resource. #2223

Closed
liverbool opened this issue Dec 5, 2014 · 11 comments
Closed

[RFC][ResourceBundle] Missing list, show events for resource. #2223

liverbool opened this issue Dec 5, 2014 · 11 comments
Labels
Feature New feature proposals. RFC Discussions about potential changes or new features.

Comments

@liverbool
Copy link
Contributor

For resource-bundle we have pre_create, post_create, .. update, delete events, I think we should have something like pre_list, post_list, pre_view, post_view too.

Benefit?

  • allow external service to subscribe and process resource e.g. we can implement acl system outside of resource-bundle.
  • and many more

/cc @Arn0d @stloyd @pjedrzejewski

@pjedrzejewski
Copy link
Member

Definitely in favor of this, I remember there was a PR with this, but not very good implementation.

@arnolanglade
Copy link
Contributor

@liverbool I am for ! @amenophis done it #305!

@amenophis
Copy link
Contributor

@Arn0d @pjedrzejewski @liverbool I can rebase if you want it !

@arnolanglade arnolanglade added RFC Discussions about potential changes or new features. ResourceBundle labels Dec 5, 2014
@liverbool
Copy link
Contributor Author

Inject ResourceResolver into DomainManager and do it like create, update..., What do you think guys?

@diimpp
Copy link
Member

diimpp commented Dec 14, 2014

👍
#1474 Same question, I believe.

@stloyd
Copy link
Contributor

stloyd commented Dec 14, 2014

@diimpp I guess more for that issue is the #2004.

@Niiko
Copy link

Niiko commented Feb 16, 2016

It would be great to have event on each resource controller action.
In that case we can compute some statistics on kernel.terminate event.

I already use it like in detailsAction on productController (but have to override that controller for that).

@michalmarcinkowski
Copy link
Contributor

There is already show event, so you can easily count number of displays etc.

@Niiko
Copy link

Niiko commented Feb 16, 2016

The show event is only triggered in backend (showAction) not in frontend display (detailsAction).

@michalmarcinkowski
Copy link
Contributor

Thanks for pointing that out! We will change that together with the new frontend.

@michalmarcinkowski
Copy link
Contributor

Fixed already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature proposals. RFC Discussions about potential changes or new features.
Projects
None yet
Development

No branches or pull requests

8 participants