Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation][Bundles] SyliusGridBundle docs update #6312

Merged
merged 6 commits into from Oct 12, 2016

Conversation

CoderMaggie
Copy link
Member

Q A
Doc fix? yes
New docs? no
BC breaks? no
Related tickets partially #5275
License MIT

@michalmarcinkowski michalmarcinkowski added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Oct 5, 2016
@ylastapis
Copy link

@TheMadeleine What about custom actions on the grid ?
Is this even possible ?

You should have a little sentence for actions in "main" section and the ones in "item" section :)

Great thanks for your job.

@CoderMaggie CoderMaggie force-pushed the docs/grid-bundle branch 2 times, most recently from 43789e2 to 356c6b4 Compare October 6, 2016 08:31
@CoderMaggie CoderMaggie changed the title [WIP][Documentation][Bundles] SyliusGridBundle docs update [Documentation][Bundles] SyliusGridBundle docs update Oct 6, 2016

The filter allows the user to select following search options:

* contains
* not contains
* equal
* starts with

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not equal is missing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no not equal :)

fields:
email:
type: string
label: app.ui.email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be app.ui.date?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but... why?

@CoderMaggie
Copy link
Member Author

@ylastapis to be honest I'm not sure about the custom actions on grids. Let me call @pjedrzejewski or @Zales0123 here 😆

driver: doctrine/orm # Use appropriate driver.
resource: app.tournament
app_admin_supplier:
...
sorting:
name: asc
Copy link
Contributor

@tuka217 tuka217 Oct 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't it expected that name is an array and the path is required?

resource: app.user # Resource name.
app_user: # Your grid name
driver: doctrine/orm # Data source driver
resource: app.user # Resource name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be:

driver: 
    name: doctrine/orm
    options:
        class: AppBundle\Entity\User

See: https://github.com/Sylius/Sylius/blob/master/src/Sylius/Bundle/AdminBundle/Resources/config/grids/channel.yml#L4

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed now! ;)

@pjedrzejewski
Copy link
Member

@ylastapis We will document that as well, but actions need to be tweaked a bit, I will take care of that soon. :)

@pjedrzejewski pjedrzejewski merged commit 99d586f into Sylius:master Oct 12, 2016
@pjedrzejewski
Copy link
Member

Thank you Magda, nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants