-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] (root) Taxon with children taxons behavior in listing #6604
Comments
@pjedrzejewski isn't this supposed to be already available for testing on http://demo.sylius.org/ ? how often do you deploy? |
The demo will be updated tomorrow to the 1.0.0-beta release 🎉 . After that we will deploy on each release. |
I believe this was not fixed the right way. Any product listing of a parent taxon must automatically include products from all its children. It is counter-intuitive and error prone for the user to have to manually add products from child taxons directly to the parent taxon. And it's especially problematic when you have a more nested hierarchy. |
And putting the |
I agree with @teohhanhui as the current behaviour has always been counterintuitive to me and AFAIK all Sylius' ElasticSearch plugins on the market solve this problem. I'm reopening this issue and tagging it as a feature, because the current behaviour has existed for so long that fixing it to show nested products could be a BC break for some. As for the second comment, could you make a separate issue for that? |
To me, the two comments are about the same issue. |
is it available for testing on demo.sylius.org? |
Not yet, you should probably need to wait for the next release. |
Would be great to have a demo preview of master branch though :) |
I totally agree too, I just don't have a time for it right now :) |
Brace yourself, @bartoszpietrzak1994 saved the day with a PR to our demo :D Sylius/SyliusDemo#49 |
And it is done :) |
Preconditions:
Steps to reproduce:
What happens:
What I think it should happen:
We have implemented such a behavior here, based on ElasticSearch:
The text was updated successfully, but these errors were encountered: