Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] [RFC] Code instead of ids for api calls #7266

Closed
lchrusciel opened this issue Jan 16, 2017 · 4 comments
Closed

[API] [RFC] Code instead of ids for api calls #7266

lchrusciel opened this issue Jan 16, 2017 · 4 comments
Labels
RFC Discussions about potential changes or new features. Stale Issues and PRs with no recent activity, about to be closed soon.

Comments

@lchrusciel
Copy link
Member

During my research for our api changes I have notice that Magento uses sku to show specific product. With our concept of immutable codes we can use them for almost all of our entities. For customers we could use an email as unique identifier. This will increase cohesion between different applications and probably it will make life easier. Should we go this way?

Check catalogProductRepositoryV1 in Magento docs.

@koemeet
Copy link
Contributor

koemeet commented Jan 17, 2017

It should be noted that this would introduce a bit more database overhead but I think it is worth it. Feels a lot better + safer to use UUIDs (or whatever you use for the code) to be used externally and auto incremented ids internally. 👍

@pjedrzejewski pjedrzejewski added the RFC Discussions about potential changes or new features. label Jan 17, 2017
@pjedrzejewski
Copy link
Member

Ref. #6560 #6801.

@lchrusciel
Copy link
Member Author

@steffenbrem absolutely. But without making any benchmarks its hard to say anything particular about performance. Index on code should also help. But I guess we will probably go this way. Let just wait for some more feedback.

@stale
Copy link

stale bot commented Feb 2, 2018

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Issues and PRs with no recent activity, about to be closed soon. label Feb 2, 2018
@stale stale bot closed this as completed Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC Discussions about potential changes or new features. Stale Issues and PRs with no recent activity, about to be closed soon.
Projects
None yet
Development

No branches or pull requests

3 participants