Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Channel] Use color input type for color #9146

Closed
Tetragramat opened this issue Feb 1, 2018 · 3 comments · Fixed by #9255
Closed

[Channel] Use color input type for color #9146

Tetragramat opened this issue Feb 1, 2018 · 3 comments · Fixed by #9255
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).

Comments

@Tetragramat
Copy link
Contributor

Q A
Bug report? no
Feature request? yes
BC Break report? no
RFC? no
Sylius version 1.x.y

Currently is used text as color input, but it is not user friendly.
@czende
Copy link
Contributor

czende commented Feb 5, 2018

You can use for example this ColorPickerBundle and extend ChannelFormType. I'm not sure if it is so important for just one single input in whole Sylius.

@Tetragramat
Copy link
Contributor Author

Tetragramat commented Feb 5, 2018 •
edited

I would like html5 color input type rather than some custom js.
http://symfony.com/doc/3.4/reference/forms/types/color.html

If I'll find some time then I'll make PR, but I want confirmation from the maintainers before that.

@Zales0123 Zales0123 added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Feb 6, 2018
@Zales0123
Copy link
Member

I think that if we can use the dedicated solution for something (especially if it does not provide any new dependencies) we should do that 👍

@Tetragramat Tetragramat mentioned this issue Mar 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changes form channel color from text to color input type
3 participants
@czende @Zales0123 @Tetragramat