Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResourceBundle][Routing] Keep a resource reference in route sylius defaults? #9702

Closed
SebLours opened this issue Sep 12, 2018 · 4 comments
Closed
Labels
Feature New feature proposals. RFC Discussions about potential changes or new features. Stale Issues and PRs with no recent activity, about to be closed soon.

Comments

@SebLours
Copy link
Contributor

I've create admin ACLs based on resource routing.
For this case, i need to group resources routes by resource alias.
I've add a reference to the resource in all resources routes.
Something like this in Sylius\Bundle\ResourceBundle\Routing\ResourceLoader:

$defaults['_sylius']['resource'] = $metadata->getAlias();

Do you think that's be usefull for others? PR?

@CoderMaggie CoderMaggie added Feature New feature proposals. RFC Discussions about potential changes or new features. labels Oct 2, 2018
@CoderMaggie
Copy link
Member

Hi Sébastien! :) Thanks for opening this issue. We are currently working on an official Sylius RBAC plugin see this issue #9508 . I'm tagging yours as Feature and RFC, and I will let you know when we will need your help in the plugin (after it goes public). Okay? :)

@stale
Copy link

stale bot commented Jan 1, 2019

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Issues and PRs with no recent activity, about to be closed soon. label Jan 1, 2019
@stale stale bot closed this as completed Jan 15, 2019
@vvasiloi
Copy link
Contributor

vvasiloi commented May 5, 2019

I wrote a command that lists all the routes generated for a resource, but because the route has no reference to the resource, I had to do a preg_match on the route name which is not reliable.
Having the resource reference would be useful.
WDYT?

@Zales0123
Copy link
Member

cc @pamil @CoderMaggie, for me introducing a _sylius -> resource parameter does not look like a 🚀 science and can be indeed useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature proposals. RFC Discussions about potential changes or new features. Stale Issues and PRs with no recent activity, about to be closed soon.
Projects
None yet
Development

No branches or pull requests

4 participants