Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core-web-bundle and sku #136

Closed
albanR opened this issue Jun 4, 2013 · 5 comments
Closed

core-web-bundle and sku #136

albanR opened this issue Jun 4, 2013 · 5 comments
Labels
Potential Bug Potential bugs or bugfixes, that needs to be reproduced.

Comments

@albanR
Copy link
Contributor

albanR commented Jun 4, 2013

Hello, 2 quick questions:

  • aren't the core and web bundle repo not updated anymore? I thought they were supposed to be in their read-only version.
  • where and when is the sku supposed to be added? Why isn't it included in the product/variant form?

Thanks!

@sargath
Copy link

sargath commented Jun 5, 2013

If I understood you right, you can update core and web bundle by git fetch / rebase i think..

I'm joining to second question too what about SKU ?

@pjedrzejewski
Copy link
Member

@albanR Sorry my update script went down. They should be updated now on daily basis.

About SKU, we have to evaluate what's the best way to deal with product identifier and decide. But I think that initially SKU will work like before and we'll introduce it to the form again. It should be optional for sure.

@albanR
Copy link
Contributor Author

albanR commented Jun 5, 2013

@pjedrzejewski sku should definitely be optional, I don't even need it in my app, just want to understand as much as possible :)
As far as core and web bundle, I am wondering from the beginning the best way to proceed:

  • integrate Sylius in a classic Symfony2 project
  • start from Sylius project and add my own bundles

I'm asking because for example, you did not include the bundle generator in Sylius? It's not difficult to reinstall but I'm wondering if there is a reason behind it or not?

@Richtermeister
Copy link
Contributor

See: #393

@stloyd
Copy link
Contributor

stloyd commented Oct 16, 2013

This was fixed by mentioned PR.

Closing.

@stloyd stloyd closed this as completed Oct 16, 2013
pamil pushed a commit to pamil/Sylius that referenced this issue Mar 21, 2016
[PromotionsBundle] Update configuration.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Potential Bug Potential bugs or bugfixes, that needs to be reproduced.
Projects
None yet
Development

No branches or pull requests

5 participants