Payment state canceled

[joostflorijn]

As far as i can see there is no payment state for payments who has been canceled. This might come in handy for the admin of the webshop, so he can see how many people start the transaction but cancel it.

[Richtermeister]

I believe the cancellation of a payment gateway payment is referred to as VOID, but I would also like some clarification on all the payment states (currently working on this part myself).

@pjedrzejewski could you briefly outline how you wanted payment states to work, and if you could, also elaborate on the role of the payment source interface? I realize that the payment bundle is probably quite WIP because of the pending Omnipay/Payum integration, and I am happy to help out if you give me some direction.

[makasim]

Just to clarify: [PoC] Sylius payum integration I am working on already contains example of status handling. You could find it usage in PurchaseStep::forwardAction() method.

[makasim]

The PaymentInterface::VOID constant was added. Any canceled payments endup with state VOID now and an admin will see `it on payment details admin page.

@pjedrzejewski I think it could be closed (Can I close or only you manage PR\Issues?)

[stloyd]

@makasim TBH. void for me is not best name, better still IMO would be simple canceled or user_canceled, just for note.

Will close after the composer.lock is updated to latest Payum version to prevent false negative issues with this.

[makasim]

@stloyd I personally prefer canceled too but void is common term, which is widely used. So renaming to canceled could confuse someone. I dont know what would work better here. tend to use void

[aniltc]

will it be available in latest sylius?

[makasim]

@aniltc it already implemented: https://github.com/Sylius/Sylius/blob/master/src/Sylius/Bundle/PaymentsBundle/Model/PaymentInterface.php#L28. and you use payum it should set correct status when a user cancel a payment.

Do you face any problems somewhere?

[stloyd]

Closing as it's implemented in core.

@aniltc If you have issue with it please open new issue about with details what's wrong.