Order Currency and Order Events

[Richtermeister]

Hi all,

I'm trying to wrap my mind around the currency attribute on the CoreBundle\Order entity.. I noticed that in the frontend order history all numbers are formatted with the default currency, regardless of which currency the customer session is set to.

This makes some sense because those numbers are historic and based on default currency calculations, and should not be converted to a rate that may have changed over time.

So, my question is: is the intention for storing the currency on the order to display historic orders in the currency they were originally placed in? If so, should we not also store the exchange rate that was in effect when the order was placed, and add an exchange rate parameter to the formatter twig extension?

Let me know and I'll do the work..

On a related subject, currently the OrderCurrencyListener is wired against an event which is never fired (sylius.order.pre_create), but it really should be triggered at the time the order is placed (completed). It seems we should have a few more events to that effect (order_placement_initialize, order_placement_success, order_placement_complete, for example).
Those events seem more relevant to order related listeners (currency, order number, inventory adjustment, etc) than the checkout events.