Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shipping rate doesn't appear in order total #428

Closed
JRomeoSalazar opened this issue Oct 17, 2013 · 6 comments · Fixed by #446
Closed

Shipping rate doesn't appear in order total #428

JRomeoSalazar opened this issue Oct 17, 2013 · 6 comments · Fixed by #446
Labels
Potential Bug Potential bugs or bugfixes, that needs to be reproduced.

Comments

@JRomeoSalazar
Copy link
Contributor

Shipping rate is not added to the order total, so the final price is wrong. How can I fix it?
@pjedrzejewski pjedrzejewski mentioned this issue Oct 23, 2013
Merged
@pjedrzejewski
Copy link
Member

@JRomeoSalazar Fixed in #446. :)

@makasim
Copy link
Contributor

makasim commented Oct 23, 2013

@pjedrzejewski this https://github.com/Sylius/Sylius/blob/master/src/Sylius/Bundle/PayumBundle/Payum/Action/CaptureOrderWithPaypalAction.php#L43 can be fixed too? I believe yes.

@cordoval
Copy link
Contributor

the call was added to the shipping processor, wouldn't the getTotal now had the shipping cost included after the fix was merged? so i guess you mean taking out one thing so not accounting for it twice right?

@pjedrzejewski
Copy link
Member

@makasim @cordoval Yes, we can use only $order.getTotal() there.

@pjedrzejewski
Copy link
Member

We must use*

@cordoval
Copy link
Contributor

like this #450 👶 ?

pamil pushed a commit to pamil/Sylius that referenced this issue Mar 21, 2016
Merge pull request Sylius#428 from lchrusciel/patch-4
e0a6b51 
Copyright year update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Potential Bug Potential bugs or bugfixes, that needs to be reproduced.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the shipping charges processor Sylius/Sylius
4 participants
@makasim @cordoval @pjedrzejewski @JRomeoSalazar