Add services aliases to improve autowiring #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
30
to
33
| <service id="sylius.grid.array_to_definition_converter" class="Sylius\Component\Grid\Definition\ArrayToDefinitionConverter"> | ||
| <argument type="service" id="event_dispatcher" /> | ||
| </service> | ||
| <service id="Sylius\Component\Grid\Definition\ArrayToDefinitionConverterInterface" alias="sylius.grid.array_to_definition_converter" /> |
There was a problem hiding this comment.
Why do you flip the alias when there's an interface?
There was a problem hiding this comment.
We need to keep the previous id and add the new service id with the interface.
There was a problem hiding this comment.
Yeah, I get that, the thing I had in mind is why not go
<service id="Sylius\Component\Grid\Definition\ArrayToDefinitionConverterInterface" class="Sylius\Component\Grid\Definition\ArrayToDefinitionConverter">
<argument type="service" id="event_dispatcher" />
</service>
<service id="sylius.grid.array_to_definition_converter" alias="Sylius\Component\Grid\Definition\ArrayToDefinitionConverterInterface" />
so the new id is always in the service definition and the old service name is aliased.
There was a problem hiding this comment.
This PR was merged into the 1.12 branch. Discussion ---------- Commits ------- 2e24d47 Fix the build
loic425
force-pushed
the
feature/add-services-aliases
branch
from
8e8dd64
to
2a46e25
Compare
loic425
changed the title
lchrusciel
approved these changes
Dec 8, 2022
lchrusciel
added
Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.