Functional tests for sending emails (via both Swiftmailer and Symfony Mailer) #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zales0123
added
Enhancement
Zales0123
force-pushed
the
test-sent-emails-ver-1
branch
4 times, most recently
from
8dfcb68
to
cfec094
Compare
Zales0123
force-pushed
the
test-sent-emails-ver-1
branch
from
cfec094
to
7f388da
Compare
lchrusciel
reviewed
Jun 21, 2022
|
|
||
| protected function setUp(): void | ||
| { | ||
| self::bootKernel(['environment' => 'test_with_swiftmailer']); |
There was a problem hiding this comment.
as we are forcing given envs in these tests, what will happen in test env (both adapters are turned on). Can we have a test for both of them enabled, but with not default adapter set?
There was a problem hiding this comment.
If no default adapter is set, then the swiftmailer adapter would be used (so it would be the same test like this one 💃). We can think about extending this test suite, but maybe it can be done in a separate PR?
GSadee
reviewed
Jun 21, 2022
It was needed to make the build green 💃 |
lchrusciel
approved these changes
Jun 22, 2022
This was referenced Jun 23, 2022
lchrusciel
added a commit
that referenced
this pull request
Jun 23, 2022
…les0123) This PR was merged into the 1.7-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | mentioned in #150 (comment) | License | MIT Commits ------- 75e74e7 Add test for Swiftmailer adapter as the default one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, there are no real functional tests in the bundle. I believe we need to finally change it and preferably do it before the next minor release 🚀
Therefore, this PR provides some basic tests that check the content of sent emails (both with Swiftmailer and Symfony Mailer). The most important changes:
test,test_with_swiftmailer,test_with_symfony_mailerandtest_no_mailer) for easier CI setupMore tests -> better 🎉