Fix session deprecation #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dannyvw
commented
Mar 13, 2022
dannyvw
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Related tickets | partially #335 |
| License | MIT |
Roshyo
approved these changes
Mar 14, 2022
lchrusciel
reviewed
Apr 15, 2022
| use Symfony\Component\HttpFoundation\RequestStack; | ||
|
|
||
| /** | ||
| * TODO Remove after bumping to > Symfony 5.x |
There was a problem hiding this comment.
What about bumping minimal requirements to 4.4 already?
There was a problem hiding this comment.
If you meant 5.4, then I agree
lchrusciel
added
Enhancement
|
Thank you, Danny! 🎉 |
lchrusciel
reviewed
Apr 15, 2022
| @@ -89,8 +103,14 @@ private function addFlash(string $type, string $message, array $parameters = []) | |||
| $message = $this->prepareMessage($message, $parameters); | |||
| } | |||
|
|
|||
| if ($this->requestStack instanceof SessionInterface) { | |||
There was a problem hiding this comment.
Having afterthought, perhaps we should wrap it into our custom class, that would do this logic?
This was referenced Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.