Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Symfony 6] Fix http foundation request handler typehints #402

Merged
merged 1 commit into from
Apr 15, 2022
Merged

[Symfony 6] Fix http foundation request handler typehints #402

merged 1 commit into from
Apr 15, 2022

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Mar 30, 2022

Q A
Bug fix? yes (Symfony 6)
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

@loic425 loic425 requested a review from a team as a code owner March 30, 2022 13:29
@loic425 loic425 changed the base branch from master to 1.8 March 30, 2022 13:29
@loic425 loic425 closed this Mar 30, 2022
@loic425 loic425 reopened this Mar 30, 2022
@loic425 loic425 changed the title Fix/http foundation request handler [Symfony 6] Fix http foundation request handler Apr 7, 2022
lchrusciel
lchrusciel reviewed Apr 15, 2022
View reviewed changes
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate on this change? Why do we conflict? Can we add it to CONFLICT.md? Other then that, it is good to go

@loic425
Copy link
Member Author

loic425 commented Apr 15, 2022 •
edited
Loading

@lchrusciel I have to remove the conflict. I just have to check if the necessary change has been merged or not.

@loic425 loic425 force-pushed the fix/http-foundation-request-handler branch from 0b1333f to fef76fd Compare April 15, 2022 12:31
@loic425 loic425 changed the title [Symfony 6] Fix http foundation request handler [Symfony 6] Fix http foundation request handler typehints Apr 15, 2022
@lchrusciel lchrusciel added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Apr 15, 2022
@lchrusciel lchrusciel changed the base branch from 1.8 to 1.10 April 15, 2022 12:35
@lchrusciel lchrusciel merged commit ab137ef into Sylius:1.10 Apr 15, 2022
@loic425 loic425 deleted the fix/http-foundation-request-handler branch April 15, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@loic425 @lchrusciel